mirror of https://github.com/lukechilds/node.git
Browse Source
The MSI install scope was set to the WiX default, which is per-user. However, with UAC, it could not be installed by a standard user because InstallPrivileges is elevated by default, hence the install scope should be set to per-machine. Furthermore, the default install path is a per-machine location and setting the system path requires administrator privileges. By changing the InstallScope to perMachine, Start Menu shortcuts are placed in ProgramData and not the installing user's AppData folder, making the shortcuts available to other users. This also fixes the installation when AppData is a network folder. The custom action is necessary to allow upgrades. Since a per-machine MSI cannot upgrade an application installed per-user, the custom action checks if there is going to be an upgrade to a previous version installed per-user and sets the installation as per-user to allow upgrading. Hence, the advantages of installing per-machine will only apply in fresh installations. Fixes #5849 Fixes #7629 PR-URL: https://github.com/joyent/node/pull/25640 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> Reviewed-By: Bert Belder <bertbelder@gmail.com>v0.12-staging
João Reis
10 years ago
committed by
Alexis Campailla
3 changed files with 67 additions and 5 deletions
@ -1,4 +1,5 @@ |
|||
LIBRARY "custom_actions" |
|||
|
|||
EXPORTS |
|||
BroadcastEnvironmentUpdate |
|||
SetInstallScope |
|||
BroadcastEnvironmentUpdate |
|||
|
Loading…
Reference in new issue