Branch: patch-14

acspeed

beta

beta_season3

blackjok3r

dPoW

dPoW2

dev

etomic

fix-mm-build

fix-mnotary_arg

jl777

master

olddPoW

pass-iguana-arg

patch-1

patch-10

patch-11

patch-12

patch-13

patch-14

patch-2

patch-3

patch-4

patch-5

patch-6

patch-7

patch-8

patch-9

quote-mnotaryrun-args

release/v0.1

win-cross

Branches Tags

${ item.name }

Create tag ${ searchTerm }

Create branch ${ searchTerm }

from 'patch-14'

${ noResults }

Commit Graph

185 Commits (patch-14)

Author	SHA1	Message	Date
DeckerSU	37bbdbe52a	fix: iguana autosplit / acsplit issue this was a most hard to find and hard to debug issue, bcz sometimes iguana did splitfunds correctly and sometimes not. nobody tried to help me to catch the "wrong state" in which it fails, despite all provided instructions. i spent all night along to catch the state of utxos in which splitfunds guarantee fails. so, i have only wallet.dat state and just every acsplit try fails on it. this was a half of victory. second stage was debugging iguana and komodod sources, adding printouts for preimage calculation, printouts for hashes, printouts for everything, launching gdb under VSCode and other things. and after spent ~24 hours of continuous work i found root of the issue. it was in spendamount (!) ... i found that dpow_gettxout returns 34.26707593 in "value" field. but after conversion to uint_64 it becomes 34.26707592 . for non-sapling enabled chains seems nothing hurts, but since sapling activated in KMD and assetchains it's significantly. bcz according to zip-243 https://github.com/zcash/zips/blob/master/zip-0243.rst amount field is a part of preimage calculation. and as we have wrong spendamount we have a wrong sighash when calc crypto_generichash_blake2b_salt_personal with sig_hash_personal = ZCASH_SIG_HASH_SAPLING_PERSONALIZATION . Look at the "Test vector 3" in ZIP-243 and amount field in preimage and you will understand the bug. Sometimes double -> uint64_t was fine and splitfunds is success, but sometimes (depends on double representation of value) it was wrong and splitfunds fails. That's why it was so hard to catch and fix. But now, seems the issue is fixed!	6 years ago
DeckerSU	323af2e008	fix splitfunds on sapling enabled coins (outputs buffer overflow fix) earlier we have fixed size buffer for outputs uint8_t outputs[1000] (derived from markemaker source), and this causes problems when we try to split over 22 duplicates, bcz in this case outputs array size overflows 1000 bytes. now memory for array allocates dynamically, depends on actual outputs size.	6 years ago
DeckerSU	739b67f0a6	sapling param added to json - added sapling param in `struct iguana_info` - each coin now have coin->sapling param (sapling=0 - sapling disabled, sapling !=0 - sapling enabled), we can set "sapling":1 in JSON when calling "addcoin" method. - removed hardcoded "VRSC" and "VRSCTEST", now we should use "sapling" param in "addcoin" method - removed unused zcash param in bitcoin_sigtxid	6 years ago
DeckerSU	30c61f0d1d	+ iguana_rwjoinsplit: add proof_size param	6 years ago
DeckerSU	4ae6fe951c	- remove debug printouts	6 years ago
DeckerSU	b280d0aa32	VRSC iguana sapling changes [part 2] - bitcoin_sigtxid sapling tx sighash preimage changes (thx to @artemii235) now splitfunds for VRSC and VRSCTEST produce correct signed txes.	6 years ago
DeckerSU	ec6d3aae31	VRSC iguana sapling changes [part 1] - already implemented unsigned raw tx creation (thx @artemii235 for mm codebase) tested on iguana_utxoduplicates (dpow is still untested) - todo: bitcoin_sigtxid implement signing for overwintered & sapling - todo: check bitcoin_verifyvins - todo: remove debug printouts	6 years ago
jl777	6362d5c75e	2017 -> 2018 in copyright notice	7 years ago
jl777	0a316c1379	test	8 years ago
jl777	f186753ab3	Test	8 years ago
jl777	dde9769590	Test	8 years ago
jl777	502faeb439	Test	8 years ago
jl777	4d45bb1ef6	Test	8 years ago
jl777	1f1c4a9e58	Test	8 years ago
jl777	e2bdf67b7e	Test	8 years ago
jl777	b806e19747	Test	8 years ago
jl777	56b6a4037a	Test	8 years ago
jl777	779732a8ba	support wifstr that encode to less than 38 bytes	8 years ago
jl777	19768b1c08	Test	8 years ago
jl777	2816d159ce	Test	8 years ago
jl777	d3506bbe93	Test	8 years ago
jl777	d3832ae69e	Test	8 years ago
jl777	f02da0c02c	Test	8 years ago
jl777	5d7c34efa0	Test	8 years ago
jl777	b90bf2654a	Test	8 years ago
jl777	3daf63b56b	Test	8 years ago
jl777	a5ffea9774	Test	8 years ago
jl777	624f9095d4	Test	8 years ago
jl777	e4be264a0d	Test	8 years ago
jl777	81857192cd	Test	8 years ago
jl777	13e29b20ff	Test	8 years ago
jl777	be1092529c	Reduce include nesting a bit	8 years ago
jl777	0468083a7b	Test	8 years ago
jl777	adac1ead6b	Test	8 years ago
jl777	3a0ad358cc	Test	8 years ago
jl777	69fdad64a4	Test	8 years ago
jl777	6b8afc8099	Test	8 years ago
jl777	da89efe292	Xcode 8	8 years ago
jl777	1d0a1ac0e5	test	8 years ago
jl777	6a401c3f44	fix for MoF partially signed	8 years ago
jl777	c9a93218f9	redundant dex* queries, iguana lock time	8 years ago
jl777	cd9b3e1312	test	8 years ago
jl777	cde6f925f2	test	8 years ago
jl777	9d46a5d9e7	test	8 years ago
jl777	9e6c852730	test	8 years ago
jl777	6518a0eb6a	test	8 years ago
jl777	373ac7bd49	test	8 years ago
jl777	a127bf97d7	test	8 years ago
jl777	e639afe3c5	test	8 years ago
jl777	b2ca7f2e22	test	8 years ago