don't know why, but in this commit ecd0f69d2f
we start count PIZZA and BEER as 3rd party coins. bcz this code adds
coin->isassetchain = 1 for all coins except PIZZA and BEER. now we
start count PIZZA and BEER as assetchains again. if this will broke something
we can always revert this commit and investigate why ecd0f69d2f
was added.
earlier it was txversion=1 for all assetchains, even sapling active,
during small bug in code. LP_coininit returns a positive (!) value of
port number (unsigned value) and we somehow was compared it with < 0 .
as a result part of code to assign txversion never executed.
this was a most hard to find and hard to debug issue, bcz sometimes
iguana did splitfunds correctly and sometimes not. nobody tried to
help me to catch the "wrong state" in which it fails, despite all
provided instructions. i spent all night along to catch the state
of utxos in which splitfunds guarantee fails. so, i have only wallet.dat
state and just every acsplit try fails on it. this was a half of victory.
second stage was debugging iguana and komodod sources, adding printouts
for preimage calculation, printouts for hashes, printouts for everything,
launching gdb under VSCode and other things. and after spent ~24 hours
of continuous work i found root of the issue.
it was in spendamount (!) ... i found that dpow_gettxout returns
34.26707593 in "value" field. but after conversion to uint_64 it becomes
34.26707592 . for non-sapling enabled chains seems nothing hurts, but
since sapling activated in KMD and assetchains it's significantly.
bcz according to zip-243 https://github.com/zcash/zips/blob/master/zip-0243.rst
amount field is a part of preimage calculation. and as we have
wrong spendamount we have a wrong sighash when calc crypto_generichash_blake2b_salt_personal
with sig_hash_personal = ZCASH_SIG_HASH_SAPLING_PERSONALIZATION .
Look at the "Test vector 3" in ZIP-243 and amount field in preimage and
you will understand the bug.
Sometimes double -> uint64_t was fine and splitfunds is success, but
sometimes (depends on double representation of value) it was wrong and
splitfunds fails. That's why it was so hard to catch and fix.
But now, seems the issue is fixed!
blackjok3r
jl777
Artem Pikulin
DeckerSU
blackjok3rtt
jl777
Jonathan "Duke" Leto
Mihail Fedorov
SHossain