From 2a084e641ccbfafb733557c065fe2460625432ad Mon Sep 17 00:00:00 2001 From: Esteban Ordano Date: Fri, 19 Dec 2014 16:36:57 -0300 Subject: [PATCH] Coverage for block and blockheader * JSDocs where already good, written by @braydonf --- lib/block.js | 1 - test/block.js | 12 ++++++++++++ test/blockheader.js | 13 +++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/block.js b/lib/block.js index 6a730af..e69fd8a 100644 --- a/lib/block.js +++ b/lib/block.js @@ -12,7 +12,6 @@ var Transaction = require('./transaction'); var Varint = require('./encoding/varint'); /** - * @class Block * Instantiate a Block from a Buffer, JSON object, or Object with * the properties of the Block * diff --git a/test/block.js b/test/block.js index 69ee9b1..0ed37ca 100644 --- a/test/block.js +++ b/test/block.js @@ -3,6 +3,7 @@ var bitcore = require('..'); var BN = require('../lib/crypto/bn'); var BufferReader = bitcore.encoding.BufferReader; +var BufferWriter = bitcore.encoding.BufferWriter; var BlockHeader = bitcore.BlockHeader; var Block = bitcore.Block; var chai = require('chai'); @@ -102,6 +103,11 @@ describe('Block', function() { should.exist(block.txs); }); + it('accepts an object as argument', function() { + var block = Block.fromRawBlock(dataRawBlockBuffer); + Block.fromJSON(block.toObject()).should.exist(); + }); + }); describe('#toJSON', function() { @@ -161,6 +167,12 @@ describe('Block', function() { block.toBufferWriter().concat().toString('hex').should.equal(blockhex); }); + it('doesn\'t create a bufferWriter if one provided', function() { + var writer = new BufferWriter(); + var block = Block.fromBuffer(blockbuf); + block.toBufferWriter(writer).should.equal(writer); + }); + }); describe('#_getHash', function() { diff --git a/test/blockheader.js b/test/blockheader.js index aae3632..bff2917 100644 --- a/test/blockheader.js +++ b/test/blockheader.js @@ -3,6 +3,8 @@ var bitcore = require('..'); var BN = require('../lib/crypto/bn'); var BufferReader = bitcore.encoding.BufferReader; +var BufferWriter = bitcore.encoding.BufferWriter; + var BlockHeader = bitcore.BlockHeader; var fs = require('fs'); var should = require('chai').should(); @@ -161,6 +163,12 @@ describe('BlockHeader', function() { BlockHeader.fromBuffer(bhbuf).toBufferWriter().concat().toString('hex').should.equal(bhhex); }); + it('doesn\'t create a bufferWriter if one provided', function() { + var writer = new BufferWriter(); + var blockHeader = BlockHeader.fromBuffer(bhbuf); + blockHeader.toBufferWriter(writer).should.equal(writer); + }); + }); describe('#inspect', function() { @@ -226,4 +234,9 @@ describe('BlockHeader', function() { }); + it('coverage: caches the "_id" property', function() { + var blockHeader = BlockHeader.fromRawBlock(dataRawBlockBuffer); + blockHeader.id.should.equal(blockHeader.id); + }); + });