Merge pull request #478 from manan19/walletkey-params

setting networks.livenet as the default for WalletKey

lib/WalletKey.js

@@ -3,11 +3,11 @@ var timeUtil = require('../util/time');
 var Key = require('./Key');
 var PrivateKey = require('./PrivateKey');
 var Address = require('./Address');
+var networks = require('../networks');
 
 function WalletKey(cfg) {
   if (!cfg) cfg = {};
-  if (!cfg.network) throw new Error('network parameter is required');
+  this.network = cfg.network || networks.livenet;
-  this.network = cfg.network; // required
   this.created = cfg.created;
   this.privKey = cfg.privKey;
 };

test/test.WalletKey.js

@@ -18,34 +18,24 @@ describe('WalletKey', function() {
     should.exist(WalletKey);
   });
   it('should be able to create instance', function() {
-    var s = new WalletKey({
+    var s = new WalletKey();
-      network: networks.livenet
-    });
     should.exist(s);
   });
   it('should be able to call generate', function() {
-    var s = new WalletKey({
+    var s = new WalletKey();
-      network: networks.livenet
-    });
     s.generate.bind(s).should.not.throw(Error);
   });
   it('should be able to call storeObj', function() {
-    var s = new WalletKey({
+    var s = new WalletKey();
-      network: networks.livenet
-    });
     s.generate();
     var o = s.storeObj();
     should.exist(o);
   });
   it('roundtrip for storeObj/fromObj', function() {
-    var s = new WalletKey({
+    var s = new WalletKey();
-      network: networks.livenet
-    });
     s.generate();
     var obj = s.storeObj();
-    var s2 = new WalletKey({
+    var s2 = new WalletKey();
-      network: networks.livenet
-    });
     s2.fromObj(obj);
     s.privKey.private.toString().should.equal(s2.privKey.private.toString());
     s.privKey.public.toString().should.equal(s2.privKey.public.toString());
@@ -69,9 +59,7 @@ describe('WalletKey', function() {
 
     //this is a WIF priv, compress flag = false 
     var priv = '5KMpLZExnGzeU3oC9qZnKBt7yejLUS8boPiWag33TMX2XEK2Ayc';
-    var s = new WalletKey({
+    var s = new WalletKey();
-      network: networks.livenet,
-    });
     s.fromObj({ priv: priv});
     s.privKey.compressed.should.equal(false);
     var o = s.storeObj();
@@ -85,9 +73,7 @@ describe('WalletKey', function() {
 
     //this is a WIF priv, compress flag = true
     var priv = 'L4cEVwoNDeYdCQfFJAGkGKPnE2TmqLEuBn4znQChD2ojjQRJVKpU';
-    var s = new WalletKey({
+    var s = new WalletKey();
-      network: networks.livenet,
-    });
     s.fromObj({ priv: priv});
     s.privKey.compressed.should.equal(true);
     var o = s.storeObj();