Braydon Fuller
589d017a14
Refactored transaction.getSerializationError to be more concise.
- _hasMoreOutputThanInput() and _isInvalidSatoshis() merged with getSerializationError()
- _isFeeDifferent(), _isFeeTooLarge() and _isFeeTooSmall merged with _hasFeeError()
10 years ago
David de Kloet
0b6eaf0f1e
Call getUnspentValue() only once in getSerializationError().
10 years ago
David de Kloet
3ace170ac5
Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled.
10 years ago
David de Kloet
ac2fbe2777
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput.
10 years ago
David de Kloet
8c5b2c851b
When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet.
10 years ago
David de Kloet
99d8ac1957
Remove an unnecessary space.
10 years ago
David de Kloet
3d9560c0c5
Don't break lines at 80 characters.
10 years ago
David de Kloet
8a8412f04a
Don't break lines at 80 characters.
10 years ago
Manuel Araoz
8a13a22baf
add Transaction#clearOutputs
10 years ago
Braydon Fuller
458abe069e
Fixed issue with handling invalid output scripts
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
10 years ago
David de Kloet
26bd5a864a
Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity.
10 years ago
Patrick Nagurny
de078a40d3
If output.script is InvalidBuffer, return null instead of throwing error
10 years ago
Braydon Fuller
53b6171547
Added coverage to transaction and fixed bug with serialization check.
10 years ago
Kirill Fomichev
346b2af446
delete writable for accessor property
10 years ago
David de Kloet
056f171e22
Remove the ability to disable the check that a specified fee is equal to the unspent value.
10 years ago
David de Kloet
b1e54101d3
Call the parent error of the fee errors FeeError for backwards compatibility.
10 years ago
David de Kloet
8da9c4a44a
Give the 3 fee errors a common parent error.
10 years ago
David de Kloet
d1eb190626
Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change.
10 years ago
David de Kloet
16dc489b08
Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified.
10 years ago
Braydon Fuller
f8ea7e39cc
Included satoshis check during checked serialization.
10 years ago
Braydon Fuller
cd12164fae
Added test coverage to transaction.verify
10 years ago
Braydon Fuller
3d447ded79
Update bn.js to 2.0.4 to handle 53 bit precision number input.
10 years ago
Manuel Araoz
d556a0c33d
fix regressions
10 years ago
Manuel Araoz
dfc075e5d1
fix block parsing problem
10 years ago
Manuel Araoz
e1921429cf
remove stray console.log
10 years ago
Manuel Araoz
9a50958943
fix Block#toObject API
10 years ago
Manuel Araoz
dff0891871
add failing test for Block#toObject
10 years ago
Daniel Cousens
05a8cf9630
sighash: remove dead branch
10 years ago
Braydon Fuller
bcd4efb724
Added `checkState` for positive integer in Output satoshis
10 years ago
Braydon Fuller
3005e19cbf
Added precondition to transaction.to for a positive integer as an amount
10 years ago
Braydon Fuller
6367cbe368
Fixed typos in transaction.verify error messages
10 years ago
Kirill Fomichev
c010cb8c50
drop cached value for inputAmount and outputAmount
10 years ago
Chris Arnesen
8af63ec8d0
update transaction.getFee() JSDoc
10 years ago
eordano
294ff097a1
Add error if shuffle function doesnt return an expected result
10 years ago
eordano
a37e7b140c
Add functionality to randomize outputs
10 years ago
Manuel Araoz
b92fd915eb
increase coverage for Input and Output, fix some bugs
10 years ago
Manuel Araoz
d5fd3919c9
add Transaction#inputAmount and outputAmount
10 years ago
eordano
405f4f43df
Update dust amount
10 years ago
eordano
2f86f323c0
Add link when throwing a serialization error
10 years ago
eordano
97671abfdc
Add more docs on serialization checks
10 years ago
eordano
b81624480a
transaction: Fix verbosity of jsdocs
10 years ago
eordano
c5d7eacfac
Add check for output amount > input amount
10 years ago
eordano
f0f90c5d6a
Change unnecesarily big name
10 years ago
eordano
a6df7a175e
Better granularity on serialize() checks
10 years ago
William Wolf
a32d8dbab8
Add block/index.js
10 years ago
William Wolf
4b601c3711
Move block.js and blockheader.js into lib/block/
10 years ago
eordano
c19d5c6501
Transaction: Check that threshold is less than amount of signatures
10 years ago
eordano
7e88167891
Add check for small fees
10 years ago
Trevin Hofmann
59a9e40f13
Properly capitalize BufferUtil everywhere
Right out of CONTRIBUTING.md
https://github.com/bitpay/bitcore/blob/master/CONTRIBUTING.md#g6---naming-utility-namespaces
10 years ago
Trevin Hofmann
ea2a0163c4
Remove redundant util requirement
The Transaction class was requiring bitcore.util.js twice, as `util` and
`JSUtil`. It seems `JSUtil` is the standard name in other classes.
10 years ago