Braydon Fuller
febbcc6a6e
Check pubkeyBuf before pubkeyBuf.length
10 years ago
Braydon Fuller
e5e783fbf9
Optimized performance of script.isPublicKeyHashIn()
10 years ago
Esteban Ordano
5882f9116e
CLTV: Minor style fix
10 years ago
Esteban Ordano
4280b993e0
Add CLTV (BIP65) support
10 years ago
Braydon Fuller
4a681f967e
Added comment with reasoning for number or array BN instantiation.
10 years ago
Braydon Fuller
08a80d74d5
more optimizations for readUInt64lebn
10 years ago
Braydon Fuller
805182c500
Removed readReverse() precondition for a 2x block parsing improvement.
10 years ago
Braydon Fuller
e74a65fd0a
Combined slice calls for performance improvement.
10 years ago
Braydon Fuller
8e6b0147b9
Fixed issue with incompatible buffer.toJSON for node 0.10 and 0.12
10 years ago
Braydon Fuller
a3dee0695d
Improved performance of bufferReader.readUInt64LEBN()
10 years ago
mruddy
9b727afc71
fix signature hasDefinedHashtype method to be closer to the Bitcoin Core function IsDefinedHashtypeSignature
10 years ago
mruddy
02cad1645a
fix root cause for bitcore.Transaction.sighash.sign not setting nhashtype.
added unit tests.
fixed an existing lint in a file that i touched.
10 years ago
Braydon Fuller
b5ada707bd
Benchmarks for block serialization & 4x performance improvement.
10 years ago
Gregg Zigler
77645c7f03
remove skipped tests since equalivant boolean tests already exist
10 years ago
Gregg Zigler
183ffab02b
match bitcore style standards, rename arg, set default to true
10 years ago
Gregg Zigler
a4b8c06a2d
get-signature-count needed to measure txs with many inputs or outputs
10 years ago
Brandon Roberts
783c59d99e
removed Networks.all and associated test
10 years ago
Brandon Roberts
e07186df07
remove unnecessary filtering code
10 years ago
Ivan Socolsky
0e6aec1c94
allow configuration of fee per kb
10 years ago
Ivan Socolsky
d9d5a26085
fix computation of fee without change output
10 years ago
Brandon Robertz
a38c0c2d93
modularize network version check/tests issues/1265
10 years ago
Kirill Fomichev
b9d52b79c8
fix Transaction.sortOutputs
10 years ago
Utente
d60d8cf2bc
fixed PrivateKey initialization from JSON
10 years ago
Braydon Fuller
5e58adca5f
Removed double errors in publickey. Fixes #1256
10 years ago
Braydon Fuller
a03e6b9385
Add base option for BN.fromString
10 years ago
Braydon Fuller
a5cd5a1407
Added support for uncompressed public keys to Signature.fromCompact
10 years ago
Braydon Fuller
589d017a14
Refactored transaction.getSerializationError to be more concise.
- _hasMoreOutputThanInput() and _isInvalidSatoshis() merged with getSerializationError()
- _isFeeDifferent(), _isFeeTooLarge() and _isFeeTooSmall merged with _hasFeeError()
10 years ago
David de Kloet
0b6eaf0f1e
Call getUnspentValue() only once in getSerializationError().
10 years ago
David de Kloet
3ace170ac5
Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled.
10 years ago
David de Kloet
ac2fbe2777
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput.
10 years ago
David de Kloet
8c5b2c851b
When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet.
10 years ago
Braydon Fuller
7723dd302a
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
10 years ago
David de Kloet
99d8ac1957
Remove an unnecessary space.
10 years ago
David de Kloet
3d9560c0c5
Don't break lines at 80 characters.
10 years ago
David de Kloet
8a8412f04a
Don't break lines at 80 characters.
10 years ago
Manuel Araoz
8a13a22baf
add Transaction#clearOutputs
10 years ago
Braydon Fuller
458abe069e
Fixed issue with handling invalid output scripts
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
10 years ago
Chris Arnesen
ec2d726e49
typo "formated"
10 years ago
David de Kloet
26bd5a864a
Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity.
10 years ago
Patrick Nagurny
de078a40d3
If output.script is InvalidBuffer, return null instead of throwing error
10 years ago
Braydon Fuller
53b6171547
Added coverage to transaction and fixed bug with serialization check.
10 years ago
Manuel Araoz
951a07c011
fix PublicKey.toObject
10 years ago
Kirill Fomichev
346b2af446
delete writable for accessor property
10 years ago
David de Kloet
056f171e22
Remove the ability to disable the check that a specified fee is equal to the unspent value.
10 years ago
David de Kloet
b1e54101d3
Call the parent error of the fee errors FeeError for backwards compatibility.
10 years ago
David de Kloet
8da9c4a44a
Give the 3 fee errors a common parent error.
10 years ago
David de Kloet
d1eb190626
Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change.
10 years ago
David de Kloet
16dc489b08
Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified.
10 years ago
Braydon Fuller
d8e90685f4
Fixed script.isPublicKeyHashIn bug with variable length signatures.
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
10 years ago
Braydon Fuller
f8ea7e39cc
Included satoshis check during checked serialization.
10 years ago