From 085b813958dc4d17af497e148c72cb52b8086bc9 Mon Sep 17 00:00:00 2001 From: Daniel Cousens Date: Wed, 4 Feb 2015 19:36:21 +1100 Subject: [PATCH] TxBuilder: replace switch lookup with object lookup --- src/transaction_builder.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/transaction_builder.js b/src/transaction_builder.js index e481fde..3b9c6a5 100644 --- a/src/transaction_builder.js +++ b/src/transaction_builder.js @@ -275,6 +275,8 @@ TransactionBuilder.prototype.__build = function(allowIncomplete) { return tx } +var canSignTypes = { 'pubkeyhash': true, 'multisig': true, 'pubkey': true } + TransactionBuilder.prototype.sign = function(index, privKey, redeemScript, hashType) { assert(index in this.inputs, 'No input at index: ' + index) hashType = hashType || Transaction.SIGHASH_ALL @@ -360,15 +362,8 @@ TransactionBuilder.prototype.sign = function(index, privKey, redeemScript, hashT input.signatures = input.signatures || [] } - switch (input.scriptType) { - case 'pubkeyhash': - case 'multisig': - case 'pubkey': - break - - default: - assert(false, input.scriptType + ' not supported') - } + // do we know how to sign this? + assert(input.scriptType in canSignTypes, input.scriptType + ' not supported') var signatureHash if (input.redeemScript) {