From 36a1d579f88281c6f48bc7c1f898e79ac178154a Mon Sep 17 00:00:00 2001 From: Daniel Cousens Date: Wed, 28 May 2014 16:19:49 +1000 Subject: [PATCH] coretests: reverse inputs for simplicity of testing To save on us building a hash map with which to check the inputs, instead I just ensure that the order of the inputs is the same as it is in the serialized transaction. --- test/fixtures/core/tx_valid.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/fixtures/core/tx_valid.json b/test/fixtures/core/tx_valid.json index 40275cd..80e26e5 100644 --- a/test/fixtures/core/tx_valid.json +++ b/test/fixtures/core/tx_valid.json @@ -53,7 +53,8 @@ ["The following tests for the presence of a bug in the handling of SIGHASH_SINGLE"], ["It results in signing the constant 1, instead of something generated based on the transaction,"], ["when the input doing the signing has an index greater than the maximum output index"], -[[["0000000000000000000000000000000000000000000000000000000000000100", 0, "DUP HASH160 0x14 0xe52b482f2faa8ecbf0db344f93c84ac908557f33 EQUALVERIFY CHECKSIG"], ["0000000000000000000000000000000000000000000000000000000000000200", 0, "1"]], +["bitcoinjs note, these inputs have been reversed for convenience, as the original data was unordered, and it is easier to check the inputs if they are ordered"], +[[["0000000000000000000000000000000000000000000000000000000000000200", 0, "1"], ["0000000000000000000000000000000000000000000000000000000000000100", 0, "DUP HASH160 0x14 0xe52b482f2faa8ecbf0db344f93c84ac908557f33 EQUALVERIFY CHECKSIG"]], "01000000020002000000000000000000000000000000000000000000000000000000000000000000000151ffffffff0001000000000000000000000000000000000000000000000000000000000000000000006b483045022100c9cdd08798a28af9d1baf44a6c77bcc7e279f47dc487c8c899911bc48feaffcc0220503c5c50ae3998a733263c5c0f7061b483e2b56c4c41b456e7d2f5a78a74c077032102d5c25adb51b61339d2b05315791e21bbe80ea470a49db0135720983c905aace0ffffffff010000000000000000015100000000", "P2SH"], ["An invalid P2SH Transaction"],