From 57a3700b32ceed1b557f9ccf095a5bc16c5cc72a Mon Sep 17 00:00:00 2001 From: Daniel Cousens Date: Tue, 3 Mar 2015 09:55:17 +1100 Subject: [PATCH] TxBuilder: fix OP_0 in buildComplete --- src/transaction_builder.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/transaction_builder.js b/src/transaction_builder.js index 8a58e9a..a50cc22 100644 --- a/src/transaction_builder.js +++ b/src/transaction_builder.js @@ -238,10 +238,15 @@ TransactionBuilder.prototype.__build = function (allowIncomplete) { }) // fill in blanks with OP_0 - for (var i = 0; i < msSignatures.length; ++i) { - if (msSignatures[i]) continue - - msSignatures[i] = ops.OP_0 + if (allowIncomplete) { + for (var i = 0; i < msSignatures.length; ++i) { + if (msSignatures[i]) continue + + msSignatures[i] = ops.OP_0 + } + } else { + // Array.prototype.filter returns non-sparse array + msSignatures = msSignatures.filter(function (x) { return x }) } var redeemScript = allowIncomplete ? undefined : input.redeemScript