From 5f8484645dacdbd1cbddae158cdf68c2a7f4bafd Mon Sep 17 00:00:00 2001 From: Daniel Cousens Date: Thu, 16 Oct 2014 01:37:38 +1100 Subject: [PATCH] remove base58check Use bs58check package solely from here on. --- src/base58check.js | 18 ------------------ src/index.js | 1 - test/base58check.js | 30 ------------------------------ test/bitcoin.core.js | 2 +- 4 files changed, 1 insertion(+), 50 deletions(-) delete mode 100644 src/base58check.js delete mode 100644 test/base58check.js diff --git a/src/base58check.js b/src/base58check.js deleted file mode 100644 index 040dd99..0000000 --- a/src/base58check.js +++ /dev/null @@ -1,18 +0,0 @@ -var bs58check = require('bs58check') - -function decode () { - console.warn('bs58check will be removed in 2.0.0. require("bs58check") instead.') - - return bs58check.decode.apply(undefined, arguments) -} - -function encode () { - console.warn('bs58check will be removed in 2.0.0. require("bs58check") instead.') - - return bs58check.encode.apply(undefined, arguments) -} - -module.exports = { - decode: decode, - encode: encode -} diff --git a/src/index.js b/src/index.js index 5dc683f..485b624 100644 --- a/src/index.js +++ b/src/index.js @@ -1,6 +1,5 @@ module.exports = { Address: require('./address'), - base58check: require('./base58check'), Block: require('./block'), bufferutils: require('./bufferutils'), crypto: require('./crypto'), diff --git a/test/base58check.js b/test/base58check.js deleted file mode 100644 index 5c0d5c4..0000000 --- a/test/base58check.js +++ /dev/null @@ -1,30 +0,0 @@ -/* global describe, it, beforeEach */ - -var assert = require('assert') -var base58check = require('../src/base58check') -var bs58check = require('bs58check') -var sinon = require('sinon') - -describe('base58check', function () { - var param - - beforeEach(function () { - param = {} - }) - - it('wraps bs58check.decode', sinon.test(function () { - var expectation = this.mock(bs58check).expects('decode') - expectation.once().calledWith(param) - expectation.onCall(0).returns('foo') - - assert.equal(base58check.decode(param), 'foo') - })) - - it('wraps bs58check.encode', sinon.test(function () { - var expectation = this.mock(bs58check).expects('encode') - expectation.once().calledWith(param) - expectation.onCall(0).returns('foo') - - assert.equal(base58check.encode(param), 'foo') - })) -}) diff --git a/test/bitcoin.core.js b/test/bitcoin.core.js index 8ad7cd1..ee7d4e8 100644 --- a/test/bitcoin.core.js +++ b/test/bitcoin.core.js @@ -2,10 +2,10 @@ var assert = require('assert') var base58 = require('bs58') +var base58check = require('bs58check') var Bitcoin = require('../') var Address = Bitcoin.Address -var base58check = Bitcoin.base58check var networks = Bitcoin.networks var ECKey = Bitcoin.ECKey var ECSignature = Bitcoin.ECSignature