Browse Source

networks: use byteLength over toBuffer

hk-custom-address
Daniel Cousens 10 years ago
parent
commit
607b3b7983
  1. 2
      src/networks.js
  2. 9
      test/networks.js

2
src/networks.js

@ -123,7 +123,7 @@ var networks = {
function estimateFee (tx, network) {
var baseFee = network.feePerKb
var byteSize = tx.toBuffer().length
var byteSize = tx.byteLength()
var fee = baseFee * Math.ceil(byteSize / 1000)
if (network.dustSoftThreshold === undefined) return fee

9
test/networks.js

@ -10,13 +10,13 @@ var Transaction = require('../src/transaction')
var fixtures = require('./fixtures/network')
describe('networks', function () {
var txToBuffer
var txByteLength
before(function () {
txToBuffer = sinon.stub(Transaction.prototype, 'toBuffer')
txByteLength = sinon.stub(Transaction.prototype, 'byteLength')
})
after(function () {
Transaction.prototype.toBuffer.restore()
Transaction.prototype.byteLength.restore()
})
describe('constants', function () {
@ -39,8 +39,7 @@ describe('networks', function () {
var network = networks[f.network]
it('calculates the fee correctly for ' + f.description, function () {
var buffer = new Buffer(f.txSize)
txToBuffer.returns(buffer)
txByteLength.returns(f.txSize)
var estimateFee = network.estimateFee
var tx = new Transaction()

Loading…
Cancel
Save