Browse Source

ECPair/HDNode: missing version from list is Unknown, not Invalid

hk-custom-address
Daniel Cousens 9 years ago
parent
commit
aae5db6a59
  1. 2
      src/ecpair.js
  2. 2
      src/hdnode.js
  3. 2
      test/fixtures/ecpair.json
  4. 2
      test/fixtures/hdnode.json

2
src/ecpair.js

@ -66,6 +66,8 @@ ECPair.fromWIF = function (string, network) {
network = network.filter(function (network) {
return version === network.wif
}).pop()
if (!network) throw new Error('Unknown network version')
}
network = network || NETWORKS.bitcoin

2
src/hdnode.js

@ -66,7 +66,7 @@ HDNode.fromBase58 = function (string, networks) {
version === network.bip32.public
}).pop()
if (!network) throw new Error('Invalid network version')
if (!network) throw new Error('Unknown network version')
// otherwise, assume a network object (or default to bitcoin)
} else {

2
test/fixtures/ecpair.json

@ -111,7 +111,7 @@
"WIF": "92Qba5hnyWSn5Ffcka56yMQauaWY6ZLd91Vzxbi4a9CCetaHtYj"
},
{
"exception": "Invalid network version",
"exception": "Unknown network version",
"WIF": "brQnSed3Fia1w9VcbbS6ZGDgJ6ENkgwuQY2LS7pEC5bKHD1fMF"
},
{

2
test/fixtures/hdnode.json

@ -199,7 +199,7 @@
"string": "xprvQQQQQQQQQQQQQQQQCviVfJSKyQ1mDYahRjijr5idH2WwLsEd4Hsb2Tyh8RfQMuPh7f7RtyzTtdrbdqqsunu5Mm3wDvUAKRHSC34sJ7in334"
},
{
"exception": "Invalid network version",
"exception": "Unknown network version",
"string": "1111111111111adADjFaSNPxwXqLjHLj4mBfYxuewDPbw9hEj1uaXCzMxRPXDFF3cUoezTFYom4sEmEVSQmENPPR315cFk9YUFVek73wE9"
},
{

Loading…
Cancel
Save