Daniel Cousens
929b8d2b62
Script: more consistent input handling
11 years ago
Daniel Cousens
7ad695e427
Script: fix assertion message grammar
11 years ago
Daniel Cousens
74e53b49a5
Script/Transaction: remove untested functions
These functions are not under test, and are unnecessary bloat due to a
confusing API.
Script.from*(asmStr) were two functions that attempted to parse ASM
codes and produce a script from this.
While useful, an parser can be introduced later under a single function
and under test... removed.
Although Script.extractPublicKeys implementation is likely to be correct,
it is not absolute in that what it returns is even strictly a set of
public keys.
It is a useful function, but can be done in a better way later,
probably checking against the Script templates instead.
Transaction.signWithKeys has some inherent undocumented behaviour, and it is not
clear when you would use it over just Transaction.addOutput and
Transaction.sign individually. Nor does it mimic anything in the
bitcoind API... removed.
11 years ago
Daniel Cousens
76323a07d0
Transaction: restrict TxIn/TxOut constructor params
To keep this change minimal, both TxIn/TxOut still use the parameter
object for initialization. TxOut accepts only the types it uses
internally, and not hex or byte arrays for scripts.
The clone is unnecessary as a TransactionOut is never mutated after its
creation.
This resulted in TransactionOut.scriptPubKey no longer being needed,
and was removed. To access the scriptPubKey as a byte buffer, a user
can simply use:
TransactionOut.script.toBuffer()
Unfortunately, this leaves TransactionOut in a sorry state of test.
Something that needs to be fixed.
11 years ago
Daniel Cousens
9a7e291d70
Transaction: fix incorrect outIndex type
11 years ago
Wei Lu
bd2a6db260
Merge pull request #172 from dcousens/ext159
Extends #159 to further verify behaviour
11 years ago
Daniel Cousens
63231fb67d
Extends test for custom Wallet change addresses
11 years ago
Daniel Cousens
a77846701f
Fixes network support for TxOut
11 years ago
Daniel Cousens
4012b82bec
Fixes Transaction.addOutput(Address, Number)
11 years ago
Daniel Cousens
695eb64a3a
Clarifies Transaction.addOutput param documentation
11 years ago
Daniel Cousens
eba08fa761
Fixes indentation for assertions
11 years ago
Daniel Cousens
d65a3c36e2
Merge pull request #159 from williamcotton/master
fixed issues with testnet and createTx
11 years ago
Wei Lu
e59f824c3a
move fixture sync script into fixtures folder
Also fixes require paths & dev dependency
11 years ago
Wei Lu
5deab5188f
Merge pull request #170 from dcousens/bufferx
BufferExt and Transaction serialization to use Buffers
11 years ago
Daniel Cousens
baa568697b
Transaction.deserialize no longer mutates input
11 years ago
Daniel Cousens
02013beda9
Renames variables to be more verbose
11 years ago
Daniel Cousens
b860daf70b
Corrects endianness comments
11 years ago
Daniel Cousens
87048d3b4e
Adds performance notes
11 years ago
Daniel Cousens
4716eb29bf
Removes redundant convert functions
11 years ago
Daniel Cousens
a8cf2fdd9e
Changes internal serialization to use Buffers instead
11 years ago
Daniel Cousens
c8bda6dde6
Adds Buffer extensions
11 years ago
Wei Lu
69f88a7404
add integration test script
11 years ago
Wei Lu
33b73517fe
fixes integration test dependency paths
11 years ago
Daniel Cousens
10ee5532c3
Serialize now returns a buffer
11 years ago
Daniel Cousens
d17f85f5a6
Changes fakeTxHash to actual hex
11 years ago
Daniel Cousens
09c6a787d9
Changes sequence number to an actual Number
11 years ago
Wei Lu
752aeae0d3
update integration test descriptions
11 years ago
Wei Lu
2affeda3f4
Restructure integration and coretests
Also update test script to pick up only tests directly under /test
11 years ago
Daniel Cousens
633b8f28d2
Fixes incorrect PubKey hex constant
11 years ago
Wei Lu
ba273db70f
Merge pull request #162 from sidazhang/master
Adding integration tests
11 years ago
Daniel Cousens
02691098de
Stretches test for derive m/0 from xpub
11 years ago
Wei Lu
a830e2cded
Merge pull request #168 from dcousens/167fix
Fixes #167
11 years ago
Daniel Cousens
ff08c2eec3
Fixes #167 and adds temporary test
11 years ago
Daniel Cousens
e6a9186af3
Removes unnecessary new Buffer
11 years ago
Daniel Cousens
e2e190c766
Variables names made consistent with constructor
11 years ago
Daniel Cousens
bb80eda218
Merge pull request #165 from bitcoinjs/bigi-monkey-patching-no-more
Upgrade bigi & remove monkey patching
11 years ago
Daniel Cousens
763e7376e9
Merge pull request #166 from bitcoinjs/remove-isfinite-check
Remove Number.isFinite check on tx input index
11 years ago
Wei Lu
1e6b283f9a
Remove Number.isFinite check on tx input index
11 years ago
Wei Lu
af1f121fd4
upgrade bigi & remove monkey patching
11 years ago
Wei Lu
39516d5532
Merge pull request #163 from dcousens/wordass
Enforces convert.wordsToBytes to only allow for byte input
11 years ago
Daniel Cousens
8b47d944b9
Merge pull request #164 from coinpunk/altcoinnetwork
Fix address prefixes, add dogecoin/litecoin BIP32 versions
11 years ago
Kyle Drake
5fd9fe62dc
Fix address prefixes, add dogecoin/litecoin BIP32 versions
11 years ago
Daniel Cousens
77747241d4
Fixes exception typo
11 years ago
Daniel Cousens
b09dd73cbe
Enforces bytesToWordArray only operates on byte arrays
11 years ago
sidazhang
fe4332bfbd
integration tests for scripthash transcations
11 years ago
Daniel Cousens
953223c818
Merge pull request #160 from bitcoinjs/signScriptSig-test
Fixes signScriptSig test
11 years ago
Wei Lu
70219c877b
Fixes signScriptSig test
11 years ago
Wei Lu
45c1c8350e
Merge pull request #154 from dcousens/convrem
Remove dead code from Convert module
11 years ago
Wei Lu
6833acaf3a
Merge pull request #152 from dcousens/p2shsign
Preliminary test for P2shsign
11 years ago
William Cotton
8f698d19f7
custom changeAddress has full integration test
11 years ago