better tests

config.js

@@ -81,6 +81,5 @@ var config = {
   //  api_user: xxx,
   //  api_key: xxx,
   // });
-  confirmationsToStartCaching: 100,
 };
 module.exports = config;

lib/common/defaults.js

@@ -70,4 +70,8 @@ Defaults.UTXO_SELECTION_MAX_FEE_VS_SINGLE_UTXO_FEE_FACTOR = 5;
 // Minimum allowed amount for tx outputs (including change) in SAT
 Defaults.MIN_OUTPUT_AMOUNT = 5000;
 
+
+Defaults.CONFIRMATIONS_TO_START_CACHING = 100;
+Defaults.HISTORY_CACHE_ADDRESS_THRESOLD = 100;
+
 module.exports = Defaults;

lib/server.js

@@ -57,7 +57,6 @@ function WalletService() {
   this.messageBroker = messageBroker;
   this.fiatRateService = fiatRateService;
   this.notifyTicker = 0;
-  this.confirmationsToStartCaching = config.confirmationsToStartCaching || 100;
 };
 
 function checkRequired(obj, args, cb) {
@@ -2789,13 +2788,18 @@ WalletService.prototype.getTxHistory = function(opts, cb) {
         bc.getTransactions(addressStrs, from, to, function(err, txs, total) {
           if (err) return cb(err);
           var txsNormalized = self._normalizeTxHistory(txs);
+          next(err, txsNormalized);
+
+          if (addresses.length < Defaults.HISTORY_CACHE_ADDRESS_THRESOLD)
+            return;
+
           var txsToCache = _.filter(txsNormalized, function(i) {
-            return i.confirmations >= self.confirmationsToStartCaching;
+            return i.confirmations >= Defaults.CONFIRMATIONS_TO_START_CACHING;
           }).reverse();
           var index = total - to;
           if (index < 0) index = 0;
           self.storage.storeTxHistoryCache(self.walletId, total, index, txsToCache, function(err) {
-            next(err, txsNormalized);
+            if (err) log.warn(err);
           })
         });
       },