From ea3a40a62797b96a556327af7929bbe1500fb52d Mon Sep 17 00:00:00 2001
From: Dan Janosik <janoside@gmail.com>
Date: Fri, 10 Aug 2018 16:05:33 -0400
Subject: [PATCH] more tweaking things related to #45

---
 app/api/coreApi.js                        |  4 +-
 app/config.js                             |  1 +
 views/includes/transaction-io-details.pug | 71 ++++++++++++++---------
 3 files changed, 46 insertions(+), 30 deletions(-)

diff --git a/app/api/coreApi.js b/app/api/coreApi.js
index d827889..852918c 100644
--- a/app/api/coreApi.js
+++ b/app/api/coreApi.js
@@ -172,7 +172,7 @@ function getMempoolDetails(start, count) {
 			}
 
 			getRawTransactions(txids).then(function(transactions) {
-				var maxInputsTracked = 10;
+				var maxInputsTracked = config.site.blockTxMaxInput;
 				var vinTxids = [];
 				for (var i = 0; i < transactions.length; i++) {
 					var transaction = transactions[i];
@@ -573,7 +573,7 @@ function getBlockByHashWithTransactions(blockHash, txLimit, txOffset) {
 					transactions.shift();
 				}
 
-				var maxInputsTracked = 10;
+				var maxInputsTracked = config.site.blockTxMaxInput;
 				var vinTxids = [];
 				for (var i = 0; i < transactions.length; i++) {
 					var transaction = transactions[i];
diff --git a/app/config.js b/app/config.js
index ff560e3..4951c74 100644
--- a/app/config.js
+++ b/app/config.js
@@ -34,6 +34,7 @@ module.exports = {
 
 	site: {
 		blockTxPageSize:20,
+		blockTxMaxInput:15,
 		browseBlocksPageSize:20
 	},
 
diff --git a/views/includes/transaction-io-details.pug b/views/includes/transaction-io-details.pug
index 4cc86cd..65943fe 100644
--- a/views/includes/transaction-io-details.pug
+++ b/views/includes/transaction-io-details.pug
@@ -7,6 +7,7 @@ div(class="row")
 	div(class="col-md-6")
 		if (txInputs)
 			table(class="table monospace mb-0")
+				- var extraInputCount = 0;
 				each txVin, txVinIndex in tx.vin
 					if (txVin.coinbase)
 						tr
@@ -24,34 +25,48 @@ div(class="row")
 								include ./value-display.pug
 
 					else
-						tr
-							th(class="pl-0 pr-1")
-								a(data-toggle="tooltip", title=("Input #" + (txVinIndex + 1)), style="white-space: nowrap;")
-									i(class=("fas fa-" + fontawesomeInputName + " mr-2"))
-									span #{(txVinIndex + 1)}
-
-							- var vout = null;
-							if (txInputs && txInputs[txVinIndex])
-								- var txInput = txInputs[txVinIndex];
-								if (txInput.vout && txInput.vout[txVin.vout])
-									- var vout = txInput.vout[txVin.vout];
-
-							td(class=(txVinIndex == 0 ? "border-top-0" : false), class="pl-0")
-								if (vout && vout.scriptPubKey && vout.scriptPubKey.addresses)
-									div(style="word-break: break-word;")
-										a(href=("/address/" + vout.scriptPubKey.addresses[0])) #{vout.scriptPubKey.addresses[0]}
-									span(class="small") via 
-										a(href=("/tx/" + txInput.txid + "#output-" + txVin.vout)) #{txInput.txid.substring(0, 20)}...[#{txVin.vout}]
-
-								else
-									span(class="text-danger") Unable to decode input
-										a(data-toggle="popover", title=JSON.stringify(txInput)) 
-											i(class="fas fa-plus-circle")
-
-							td(class=(txInputIndex == 0 ? "border-top-0" : false), class="pl-0 text-right")
-								if (vout && vout.value)
-									- var currencyValue = vout.value;
-									include ./value-display.pug
+						- var vout = null;
+						if (txInputs && txInputs[txVinIndex])
+							- var txInput = txInputs[txVinIndex];
+							if (txInput.vout && txInput.vout[txVin.vout])
+								- var vout = txInput.vout[txVin.vout];
+
+						if (vout)
+							tr
+								th(class="pl-0 pr-1")
+									a(data-toggle="tooltip", title=("Input #" + (txVinIndex + 1)), style="white-space: nowrap;")
+										i(class=("fas fa-" + fontawesomeInputName + " mr-2"))
+										span #{(txVinIndex + 1)}
+
+								td(class=(txVinIndex == 0 ? "border-top-0" : false), class="pl-0")
+									if (vout && vout.scriptPubKey && vout.scriptPubKey.addresses)
+										div(style="word-break: break-word;")
+											a(href=("/address/" + vout.scriptPubKey.addresses[0])) #{vout.scriptPubKey.addresses[0]}
+										span(class="small") via 
+											a(href=("/tx/" + txInput.txid + "#output-" + txVin.vout)) #{txInput.txid.substring(0, 20)}...[#{txVin.vout}]
+
+								td(class=(txVinIndex == 0 ? "border-top-0" : false), class="pl-0 text-right")
+									if (vout && vout.value)
+										- var currencyValue = vout.value;
+										include ./value-display.pug
+						else
+							- extraInputCount = extraInputCount + 1;
+
+				if (extraInputCount > 0)
+					tr
+						th(class="pl-0 pr-1")
+
+						td(class="border-top-0 pl-0")
+							span #{extraInputCount} Additonal 
+							if (extraInputCount != 1)
+								span inputs 
+							else
+								span input 
+								
+							a(data-toggle="tooltip", title="Additional inputs withheld for performance. See this transaction's details page for more info.")
+								i(class="fas fa-info-circle")
+							
+						td(class="border-top-0")
 
 				tr
 					th