From 2409782975d15213804aa80614a322262cd32084 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Sun, 23 Feb 2020 19:53:41 +0100 Subject: [PATCH] qt open channel: early return if fields are left empty closes #5934 --- electrum/gui/qt/channels_list.py | 2 ++ electrum/gui/qt/confirm_tx_dialog.py | 1 + 2 files changed, 3 insertions(+) diff --git a/electrum/gui/qt/channels_list.py b/electrum/gui/qt/channels_list.py index d56b06dc6..b19c0d1c4 100644 --- a/electrum/gui/qt/channels_list.py +++ b/electrum/gui/qt/channels_list.py @@ -256,4 +256,6 @@ class ChannelsList(MyTreeView): else: funding_sat = amount_e.get_amount() connect_str = str(remote_nodeid.text()).strip() + if not connect_str or not funding_sat: + return self.parent.open_channel(connect_str, funding_sat, 0) diff --git a/electrum/gui/qt/confirm_tx_dialog.py b/electrum/gui/qt/confirm_tx_dialog.py index 3d274d9c8..ee5e35c2f 100644 --- a/electrum/gui/qt/confirm_tx_dialog.py +++ b/electrum/gui/qt/confirm_tx_dialog.py @@ -175,6 +175,7 @@ class ConfirmTxDialog(TxEditor, WindowModalDialog): password = self.pw.text() or None if self.password_required: if password is None: + self.main_window.show_error(_("Password required"), parent=self) return try: self.wallet.check_password(password)