Browse Source

crash reporter: propagate HTTP error as exception

which will then get displayed as an error, and not as if we succeeded sending...
bip39-recovery
SomberNight 5 years ago
parent
commit
240c823e8b
No known key found for this signature in database GPG Key ID: B33B5F232C6271E9
  1. 2
      electrum/base_crash_reporter.py
  2. 2
      electrum/gui/qt/exception_window.py

2
electrum/base_crash_reporter.py

@ -75,7 +75,7 @@ class BaseCrashReporter(Logger):
async def do_post(self, proxy, url, data):
async with make_aiohttp_session(proxy) as session:
async with session.post(url, data=data) as resp:
async with session.post(url, data=data, raise_for_status=True) as resp:
return await resp.text()
def get_traceback_info(self):

2
electrum/gui/qt/exception_window.py

@ -117,7 +117,7 @@ class Exception_Window(BaseCrashReporter, QWidget, MessageBoxMixin, Logger):
self.logger.error('There was a problem with the automatic reporting', exc_info=exc_info)
self.show_critical(parent=self,
msg=(_('There was a problem with the automatic reporting:') + '<br/>' +
repr(e)[:120] + '<br/>' +
repr(e)[:120] + '<br/><br/>' +
_("Please report this issue manually") +
f' <a href="{constants.GIT_REPO_ISSUES_URL}">on GitHub</a>.'),
rich_text=True)

Loading…
Cancel
Save