diff --git a/electrum/lnchannel.py b/electrum/lnchannel.py index 6a50ba686..bd8287974 100644 --- a/electrum/lnchannel.py +++ b/electrum/lnchannel.py @@ -858,6 +858,7 @@ class Channel(AbstractChannel): local_ctn = self.get_latest_ctn(LOCAL) remote_ctn = self.get_latest_ctn(REMOTE) if onion_packet: + # TODO neither local_ctn nor remote_ctn are used anymore... no point storing them. self.hm.log['unfulfilled_htlcs'][htlc.htlc_id] = local_ctn, remote_ctn, onion_packet.hex(), False self.logger.info("receive_htlc") diff --git a/electrum/lnpeer.py b/electrum/lnpeer.py index 89eb4f1bd..c895ad056 100644 --- a/electrum/lnpeer.py +++ b/electrum/lnpeer.py @@ -1666,10 +1666,7 @@ class Peer(Logger): done = set() unfulfilled = chan.hm.log.get('unfulfilled_htlcs', {}) for htlc_id, (local_ctn, remote_ctn, onion_packet_hex, forwarding_info) in unfulfilled.items(): - # FIXME this test is not sufficient: - if chan.get_oldest_unrevoked_ctn(LOCAL) <= local_ctn: - continue - if chan.get_oldest_unrevoked_ctn(REMOTE) <= remote_ctn: + if not chan.hm.is_add_htlc_irrevocably_committed_yet(htlc_proposer=REMOTE, htlc_id=htlc_id): continue chan.logger.info(f'found unfulfilled htlc: {htlc_id}') htlc = chan.hm.get_htlc_by_id(REMOTE, htlc_id)