From 3090cc68bb96d683e1e286781dba82e008611250 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Sun, 1 Mar 2020 09:32:05 +0100 Subject: [PATCH] Qt tx dialog: show txid as "unknown" while not finalized --- electrum/gui/qt/transaction_dialog.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/electrum/gui/qt/transaction_dialog.py b/electrum/gui/qt/transaction_dialog.py index 8cf26c756..895201c17 100644 --- a/electrum/gui/qt/transaction_dialog.py +++ b/electrum/gui/qt/transaction_dialog.py @@ -417,7 +417,12 @@ class BaseTxDialog(QDialog, MessageBoxMixin): can_sign = not self.tx.is_complete() and \ (self.wallet.can_sign(self.tx) or bool(self.external_keypairs)) self.sign_button.setEnabled(can_sign) - self.tx_hash_e.setText(tx_details.txid or _('Unknown')) + if self.finalized and tx_details.txid: + self.tx_hash_e.setText(tx_details.txid) + else: + # note: when not finalized, RBF and locktime changes do not trigger + # a make_tx, so the txid is unreliable, hence: + self.tx_hash_e.setText(_('Unknown')) if desc is None: self.tx_desc.hide() else: