From 9c2807cbb183ff9a51f23d0764b306a3fcb69790 Mon Sep 17 00:00:00 2001 From: SomberNight Date: Mon, 19 Jul 2021 16:13:27 +0200 Subject: [PATCH] mac build: README: clarify note about reproducibility of unsigned dmg --- contrib/osx/README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/contrib/osx/README.md b/contrib/osx/README.md index d217ce463..0bbb1e170 100644 --- a/contrib/osx/README.md +++ b/contrib/osx/README.md @@ -89,5 +89,8 @@ repository. ``` $ ./contrib/osx/compare_dmg dist/electrum-*.dmg electrum_dmg_official_release.dmg ``` - The `compare_dmg` is only needed as the official release binary is codesigned and notarized. - Otherwise, the built dmg files should be byte-identical. + The `compare_dmg` script is mostly only needed as the official release binary is + codesigned and notarized. Otherwise, the built `.app` bundles should be byte-identical. + (Note that we are using `hdutil` to create the `.dmg`, and its output is not + deterministic, but we cannot compare the `.dmg` files directly anyway as they contain + codesigned files)