From d2019fd928bcb46590f128ae6b11eaaa1f6814af Mon Sep 17 00:00:00 2001 From: SomberNight Date: Mon, 15 Feb 2021 10:15:30 +0100 Subject: [PATCH] qt bump fee: rename "Final" checkbox to "Keep Replace-By-Fee enabled" Now that the checkbox is hidden behind an advanced option, there is no need to be brief about it, better to be explicit. (terminology unchanged for kivy.) --- electrum/gui/qt/rbf_dialog.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/electrum/gui/qt/rbf_dialog.py b/electrum/gui/qt/rbf_dialog.py index 843dc4c7d..168445269 100644 --- a/electrum/gui/qt/rbf_dialog.py +++ b/electrum/gui/qt/rbf_dialog.py @@ -115,20 +115,21 @@ class _BaseRBFDialog(WindowModalDialog): vbox.addWidget(adv_widget) def _add_advanced_options(self, adv_vbox: QVBoxLayout) -> None: - self.cb_is_final = QCheckBox(_('Final')) - adv_vbox.addWidget(self.cb_is_final) + self.cb_rbf = QCheckBox(_('Keep Replace-By-Fee enabled')) + self.cb_rbf.setChecked(True) + adv_vbox.addWidget(self.cb_rbf) def run(self) -> None: if not self.exec_(): return - is_final = self.cb_is_final.isChecked() + is_rbf = self.cb_rbf.isChecked() new_fee_rate = self.feerate_e.get_amount() try: new_tx = self.rbf_func(new_fee_rate) except Exception as e: self.window.show_error(str(e)) return - new_tx.set_rbf(not is_final) + new_tx.set_rbf(is_rbf) tx_label = self.wallet.get_label_for_txid(self.txid) self.window.show_transaction(new_tx, tx_desc=tx_label) # TODO maybe save tx_label as label for new tx?? @@ -163,8 +164,9 @@ class BumpFeeDialog(_BaseRBFDialog): ) def _add_advanced_options(self, adv_vbox: QVBoxLayout) -> None: - self.cb_is_final = QCheckBox(_('Final')) - adv_vbox.addWidget(self.cb_is_final) + self.cb_rbf = QCheckBox(_('Keep Replace-By-Fee enabled')) + self.cb_rbf.setChecked(True) + adv_vbox.addWidget(self.cb_rbf) self.strat_combo = QComboBox() options = [