Browse Source

qt ConfirmTxDialog: don't catch BaseException for make_tx

not sure what it is supposed to catch...
The examples I could come up with would all be actual bugs;
in which case we should let the exception propagate out to the crash reporter.
hard-fail-on-bad-server-string
SomberNight 5 years ago
parent
commit
e0eb3c18eb
No known key found for this signature in database GPG Key ID: B33B5F232C6271E9
  1. 5
      electrum/gui/qt/confirm_tx_dialog.py

5
electrum/gui/qt/confirm_tx_dialog.py

@ -99,11 +99,6 @@ class TxEditor:
self.tx = None
self.main_window.show_error(str(e))
raise
except BaseException as e:
self.tx = None
self.main_window.logger.exception('')
self.show_message(str(e))
return
use_rbf = bool(self.config.get('use_rbf', True))
if use_rbf:
self.tx.set_rbf(True)

Loading…
Cancel
Save