happened for me at least once, but for some reason kivy actually "ignored the exception", and simply printed a long trace into logcat, starting with:
WARNING:kivy:stderr: Exception ignored in: 'kivy.core.window._window_sdl2._WindowSDL2Storage.cb_event_filter'
saved wallet = "wallet that was last open during a graceful shutdown"
previously we would just try to open "default_wallet". now, if the deleted wallet is not the saved wallet, we open the saved wallet; else try to open "default_wallet". if "default_wallet" does not exist, as before, the wizard launches.
* Rename synchronous_get to synchronous_send
This makes it more inline with the method 'send' of which
synchronous_send is the, well, synchronous version.
* Move protocol strings from scripts to network
This is again a small step in the right direction. The network module is
going to accumulate more and more of these simple methods. Once
everything is moved into that module, that module is going to be split.
Note that I've left the scripts which use scripts/util.py alone. I
suspect the same functionality can be reached when using just
lib/network.py and that scripts/util.py is obsolete.
* Remove protocol string from verifier and websocket
Websocket still has some references, that'll take more work to remove. Once the
network module has been split this should be easy.
I took the liberty to rename a variable to better show what it is.
* Remove protocol strings from remainder
The naming scheme I'm following for the newly introduced methods in the network
module is: 'blockchain.<subject>.<action>' -> def <action>_(for|to)_<subject>
* Move explicit protocol calls closer to each other
This makes it easier to keep track of the methods which are due to be
extracted.
* Remove `send` when using `get_transaction`
This is the final step to formalize (the informal) interface of the network
module.
A chance of note is changed interface for async/sync calls. It is no longer
required to use the `synchronous_send` call. Merely NOT passing a callback
makes the call synchronous. I feel this makes the API more intuitive to work
with and easier to replace with a different network module.
* Remove send from get_merkle_for_transaction
The pattern which emerged for calling the lambda yielded an slight refactor.
I'm not happy with the name for the `__invoke` method.
* Remove explict send from websockets
* Remove explicit send from scripts
* Remove explicit send from wallet
* Remove explicit sync_send from commands, scripts
* Remove optional timeout parameter
This parameter doesn't seem to be used a lot and removing it makes the
remaining calls easier. Potentionally a contentious choice!
* Rename `broadcast` to `broadcast_transaction`
Doing so makes the method name consistent with the other ElectrumX protocol
method names.
* Remove synchronous_send
Now every method is intuitive in what it does, no special handling required.
The `broadcast_transaction` method is weird. I've opted not to change the
return type b/c I found it hard to know what the exact consequences are. But
ideally this method should just works as all the other ElectrumX related
messages. On the other hand this shows nicely how you _can_ do something
differnt quite easy.
* Rename the awkwardly name `__invoke` method
The new name reflects what it does.
* Process the result of linter feedback
I've used flake8-diff (and ignored a couple of line length warnings).
* Rename tx_response to on_tx_response
This fell through the cracks when this branch was rebased.
* subscript_to_scripthash should be get_balance
An oversight while refactoring.
* Add missing return statement
Without this statement the transaction would have been broadcasted twice.
* Pass list of tuples to send not single tuple
* Add @staticmethod decorator
* Fix argument to be an array
- Use server.ping to ping (valid as of protocol version 1.2) rather
than server.version (deprecated as a ping)
- Ping every 5 mins rather than every 1 minute. By default servers
don't consider a connection stale until 10 minutes of inactivity.
- Remove unused last_request member of interface
Port of c3f26e59db
Only actually needed due to Imported_Wallet.delete_address, but it takes some time to see this.
The verifier and the synchronizer both access unverified_tx but they are both run in the Network thread.
In any case, there does not seem to be a measurable performance hit when using the lock.
notably Trezor T is returning a different msg type when trying to get an xpub from an uninitialized device, which we are not handling. instead we should just realise ourselves that we did not initialize the device
Anilkumar18
ThomasV
SomberNight
matejcik
Dev Random
Harm Aarts
Neil Booth
Johann Bauer