isKnown const&

libethereum/ClientBase.cpp

@@ -481,7 +481,7 @@ int ClientBase::compareBlockHashes(h256 _h1, h256 _h2) const
 	return -1;
 }
 
-bool ClientBase::isKnown(h256 _hash) const
+bool ClientBase::isKnown(h256 const& _hash) const
 {
 	return _hash == PendingBlockHash ||
 		_hash == LatestBlockHash ||
@@ -496,7 +496,7 @@ bool ClientBase::isKnown(BlockNumber _block) const
 		bc().numberHash(_block) != h256();
 }
 
-bool ClientBase::isKnownTransaction(h256 _transactionHash) const
+bool ClientBase::isKnownTransaction(h256 const& _transactionHash) const
 {
 	return bc().isKnownTransaction(_transactionHash);
 }

libethereum/ClientBase.h

@@ -149,9 +149,9 @@ public:
 	/// Get the coinbase address
 	virtual Address address() const override;
 
-	virtual bool isKnown(h256 _hash) const override;
+	virtual bool isKnown(h256 const& _hash) const override;
 	virtual bool isKnown(BlockNumber _block) const override;
-	virtual bool isKnownTransaction(h256 _transactionHash) const override;
+	virtual bool isKnownTransaction(h256 const& _transactionHash) const override;
 
 	/// TODO: consider moving it to a separate interface
 

libethereum/Interface.h

@@ -133,7 +133,7 @@ public:
 
 	// [BLOCK QUERY API]
 
-	virtual bool isKnownTransaction(h256 _transactionHash) const = 0;
+	virtual bool isKnownTransaction(h256 const& _transactionHash) const = 0;
 	virtual Transaction transaction(h256 _transactionHash) const = 0;
 	virtual std::pair<h256, unsigned> transactionLocation(h256 const& _transactionHash) const = 0;
 	virtual h256 hashFromNumber(BlockNumber _number) const = 0;
@@ -141,7 +141,7 @@ public:
 	virtual int compareBlockHashes(h256 _h1, h256 _h2) const = 0;
 
 	virtual bool isKnown(BlockNumber _block) const = 0;
-	virtual bool isKnown(h256 _hash) const = 0;
+	virtual bool isKnown(h256 const& _hash) const = 0;
 	virtual BlockInfo blockInfo(h256 _hash) const = 0;
 	virtual BlockDetails blockDetails(h256 _hash) const = 0;
 	virtual Transaction transaction(h256 _blockHash, unsigned _i) const = 0;