From 3da758ccbbf451ddd593093a528bfbc344642ed8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Bylica?= Date: Fri, 27 Feb 2015 19:16:26 +0100 Subject: [PATCH] Delete old memory pointers --- evmjit/libevmjit/Common.h | 2 -- evmjit/libevmjit/ExecStats.h | 1 + evmjit/libevmjit/Runtime.h | 9 +++------ evmjit/libevmjit/RuntimeManager.cpp | 6 ++---- evmjit/libevmjit/Stack.cpp | 3 --- 5 files changed, 6 insertions(+), 15 deletions(-) diff --git a/evmjit/libevmjit/Common.h b/evmjit/libevmjit/Common.h index cd0523b12..7e3380c2e 100644 --- a/evmjit/libevmjit/Common.h +++ b/evmjit/libevmjit/Common.h @@ -1,6 +1,5 @@ #pragma once -#include #include #include @@ -18,7 +17,6 @@ namespace jit { using byte = uint8_t; -using bytes = std::vector; using bytes_ref = std::tuple; using code_iterator = byte const*; diff --git a/evmjit/libevmjit/ExecStats.h b/evmjit/libevmjit/ExecStats.h index 1ac9b6995..0451ccb05 100644 --- a/evmjit/libevmjit/ExecStats.h +++ b/evmjit/libevmjit/ExecStats.h @@ -1,5 +1,6 @@ #pragma once +#include #include #include diff --git a/evmjit/libevmjit/Runtime.h b/evmjit/libevmjit/Runtime.h index 4755a8698..895128a59 100644 --- a/evmjit/libevmjit/Runtime.h +++ b/evmjit/libevmjit/Runtime.h @@ -8,7 +8,6 @@ namespace eth { namespace jit { -using MemoryImpl = bytes; class Runtime { @@ -21,11 +20,9 @@ public: private: RuntimeData* m_data = nullptr; ///< Pointer to data. Expected by compiled contract. Env* m_env = nullptr; ///< Pointer to environment proxy. Expected by compiled contract. - byte* m_memoryData = nullptr; - i256 m_memorySize; - byte* m_memData; - uint64_t m_memSize; - uint64_t m_memCap; + byte* m_memData = nullptr; + uint64_t m_memSize = 0; + uint64_t m_memCap = 0; }; } diff --git a/evmjit/libevmjit/RuntimeManager.cpp b/evmjit/libevmjit/RuntimeManager.cpp index f6b5df43e..87b47c057 100644 --- a/evmjit/libevmjit/RuntimeManager.cpp +++ b/evmjit/libevmjit/RuntimeManager.cpp @@ -51,9 +51,7 @@ llvm::StructType* RuntimeManager::getRuntimeType() { Type::RuntimeDataPtr, // data Type::EnvPtr, // Env* - Type::BytePtr, // memory data - Type::Word, // memory size - Array::getType() + Array::getType() // memory }; type = llvm::StructType::create(elems, "Runtime"); } @@ -100,7 +98,7 @@ RuntimeManager::RuntimeManager(llvm::IRBuilder<>& _builder, llvm::Value* _jmpBuf assert(m_dataPtr->getType() == Type::RuntimeDataPtr); m_gasPtr = m_builder.CreateStructGEP(m_dataPtr, 0, "gas"); assert(m_gasPtr->getType() == Type::Gas->getPointerTo()); - m_memPtr = m_builder.CreateStructGEP(rtPtr, 4, "mem"); + m_memPtr = m_builder.CreateStructGEP(rtPtr, 2, "mem"); assert(m_memPtr->getType() == Array::getType()->getPointerTo()); m_envPtr = m_builder.CreateLoad(m_builder.CreateStructGEP(rtPtr, 1), "env"); assert(m_envPtr->getType() == Type::EnvPtr); diff --git a/evmjit/libevmjit/Stack.cpp b/evmjit/libevmjit/Stack.cpp index 85bd98fdd..3a686c766 100644 --- a/evmjit/libevmjit/Stack.cpp +++ b/evmjit/libevmjit/Stack.cpp @@ -158,7 +158,6 @@ llvm::Value* Stack::get(size_t _index) void Stack::set(size_t _index, llvm::Value* _value) { m_stack.set(m_builder.CreateSub(m_stack.size(), m_builder.getInt64(_index + 1)), _value); - //createCall(getSetFunc(), {m_runtimeManager.getRuntimePtr(), m_builder.getInt64(_index), _value}); } void Stack::pop(size_t _count) @@ -166,13 +165,11 @@ void Stack::pop(size_t _count) // FIXME: Pop does not check for stack underflow but looks like not needed // We should place stack.require() check and begining of every BB m_stack.pop(m_builder.getInt64(_count)); - //createCall(getPopFunc(), {m_runtimeManager.getRuntimePtr(), m_builder.getInt64(_count), m_runtimeManager.getJmpBuf()}); } void Stack::push(llvm::Value* _value) { m_stack.push(_value); - //createCall(getPushFunc(), {m_runtimeManager.getRuntimePtr(), _value}); } }