From 13ee1d0f511e94e2181842fb2c725eba4d55e836 Mon Sep 17 00:00:00 2001
From: arkpar <arkady.paronyan@gmail.com>
Date: Fri, 20 Feb 2015 14:05:44 +0100
Subject: [PATCH 1/2] use windeployqt for deployment on windows

---
 cmake/EthDependencies.cmake     |  5 ++++
 cmake/EthExecutableHelper.cmake | 46 +++++----------------------------
 2 files changed, 12 insertions(+), 39 deletions(-)

diff --git a/cmake/EthDependencies.cmake b/cmake/EthDependencies.cmake
index fb6b09bb8..3f6cbcd77 100644
--- a/cmake/EthDependencies.cmake
+++ b/cmake/EthDependencies.cmake
@@ -128,6 +128,11 @@ if (NOT HEADLESS)
 		set (MACDEPLOYQT_APP ${Qt5Core_DIR}/../../../bin/macdeployqt)
 		message(" - macdeployqt path: ${MACDEPLOYQT_APP}")
 	endif()
+	# we need to find path to windeployqt on windows
+	if (WIN32)
+		set (WINDEPLOYQT_APP ${Qt5Core_DIR}/../../../bin/windeployqt)
+		message(" - windeployqt path: ${WINDEPLOYQT_APP}")
+	endif()
 
 # TODO check node && npm version
 	find_program(ETH_NODE node)
diff --git a/cmake/EthExecutableHelper.cmake b/cmake/EthExecutableHelper.cmake
index 427e0a9c4..7d6edef34 100644
--- a/cmake/EthExecutableHelper.cmake
+++ b/cmake/EthExecutableHelper.cmake
@@ -63,7 +63,7 @@ macro(eth_install_executable EXECUTABLE)
 		if (APPLE)
 			set(eth_qml_dir "-qmldir=${ETH_INSTALL_EXECUTABLE_QMLDIR}")
 		elseif (WIN32)
-			set(eth_qml_dir --qmldir ${ETH_INSTALL_EXECUTABLE_QMLDIR})
+			set(eth_qml_dir "--qmldir ${ETH_INSTALL_EXECUTABLE_QMLDIR}")
 		endif()
 		message(STATUS "${EXECUTABLE} qmldir: ${eth_qml_dir}")
 	endif()
@@ -88,49 +88,17 @@ macro(eth_install_executable EXECUTABLE)
 			set(BU_CHMOD_BUNDLE_ITEMS 1)
 			verify_app(\"${APP_BUNDLE_PATH}\")
 			" COMPONENT RUNTIME )
-	elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
-
-		# copy all dlls to executable directory
-		# TODO improve that by copying only required dlls
-		file (GLOB DLLS ${ETH_DEPENDENCY_INSTALL_DIR}/bin/*.dll)
-
-		foreach(DLL ${DLLS})
-			add_custom_command(TARGET ${EXECUTABLE} POST_BUILD
-				COMMAND cmake -E copy "${DLL}" "$<TARGET_FILE_DIR:${EXECUTABLE}>"
-			)
-		endforeach()
 
+	elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
 		add_custom_command(TARGET ${EXECUTABLE} POST_BUILD
-			COMMAND cmake -E copy_directory
-			"${ETH_DEPENDENCY_INSTALL_DIR}/plugins/platforms"
-			$<TARGET_FILE_DIR:${EXECUTABLE}>/platforms
+			COMMAND cmd /C "set PATH=${Qt5Core_DIR}/../../../bin;%PATH% && ${WINDEPLOYQT_APP} ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${EXECUTABLE}.exe ${eth_qml_dir} --verbose 100"
+			WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
 		)
-
-		# ugly way, improve that
+		#workaround for https://bugreports.qt.io/browse/QTBUG-42083
 		add_custom_command(TARGET ${EXECUTABLE} POST_BUILD
-			COMMAND cmake -E copy_directory
-			"${ETH_DEPENDENCY_INSTALL_DIR}/qml"
-			$<TARGET_FILE_DIR:${EXECUTABLE}>
-		)
-
-		install( FILES ${DLLS} 
-			DESTINATION bin
-			COMPONENT ${EXECUTABLE}
-		)
-
-		install( DIRECTORY ${ETH_DEPENDENCY_INSTALL_DIR}/plugins/platforms 
-			DESTINATION bin
-			COMPONENT ${EXECUTABLE}
+			COMMAND cmd /C "(echo [Paths] & echo.Prefix=.)" > "qt.conf"
+			WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR} VERBATIM
 		)
-
-		file (GLOB QMLS ${ETH_DEPENDENCY_INSTALL_DIR}/qml/*)
-		foreach(QML ${QMLS})
-			install( DIRECTORY ${QML} 
-				DESTINATION bin
-				COMPONENT ${EXECUTABLE}
-			)
-		endforeach()
-
 		install( TARGETS ${EXECUTABLE} RUNTIME 
 			DESTINATION bin
 			COMPONENT ${EXECUTABLE}

From f71337400b88716a3daa27a2aefe7edcc42d6652 Mon Sep 17 00:00:00 2001
From: arkpar <arkady.paronyan@gmail.com>
Date: Fri, 20 Feb 2015 15:47:07 +0100
Subject: [PATCH 2/2] removed verbosity flag

---
 cmake/EthExecutableHelper.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmake/EthExecutableHelper.cmake b/cmake/EthExecutableHelper.cmake
index 7d6edef34..c6e0210de 100644
--- a/cmake/EthExecutableHelper.cmake
+++ b/cmake/EthExecutableHelper.cmake
@@ -91,7 +91,7 @@ macro(eth_install_executable EXECUTABLE)
 
 	elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
 		add_custom_command(TARGET ${EXECUTABLE} POST_BUILD
-			COMMAND cmd /C "set PATH=${Qt5Core_DIR}/../../../bin;%PATH% && ${WINDEPLOYQT_APP} ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${EXECUTABLE}.exe ${eth_qml_dir} --verbose 100"
+			COMMAND cmd /C "set PATH=${Qt5Core_DIR}/../../../bin;%PATH% && ${WINDEPLOYQT_APP} ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}/${EXECUTABLE}.exe ${eth_qml_dir}"
 			WORKING_DIRECTORY ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}
 		)
 		#workaround for https://bugreports.qt.io/browse/QTBUG-42083