diff --git a/libsolidity/Types.cpp b/libsolidity/Types.cpp index d861980d0..3a4112c45 100644 --- a/libsolidity/Types.cpp +++ b/libsolidity/Types.cpp @@ -56,7 +56,6 @@ shared_ptr Type::fromElementaryTypeName(Token::Value _typeToken) else BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Unable to convert elementary typename " + std::string(Token::toString(_typeToken)) + " to type.")); - return shared_ptr(); } shared_ptr Type::fromUserDefinedTypeName(UserDefinedTypeName const& _typeName) @@ -67,7 +66,6 @@ shared_ptr Type::fromUserDefinedTypeName(UserDefinedTypeName const& _typeN shared_ptr Type::fromMapping(Mapping const&) { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Mapping types not yet implemented.")); - return shared_ptr(); } shared_ptr Type::forLiteral(Literal const& _literal) diff --git a/libsolidity/Types.h b/libsolidity/Types.h index df48418b5..607ee3a6f 100644 --- a/libsolidity/Types.h +++ b/libsolidity/Types.h @@ -201,7 +201,7 @@ public: virtual bool operator==(Type const& _other) const override; virtual std::string toString() const override { return "function(...)returns(...)"; } - virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable function type requested.")); return 1; } + virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable function type requested.")); } private: FunctionDefinition const& m_function; @@ -235,7 +235,7 @@ public: VoidType() {} virtual std::string toString() const override { return "void"; } - virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable void type requested.")); return 1; } + virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable void type requested.")); } }; /** @@ -251,7 +251,7 @@ public: std::shared_ptr const& getActualType() const { return m_actualType; } virtual bool operator==(Type const& _other) const override; - virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable type type requested.")); return 1; } + virtual u256 getStorageSize() const { BOOST_THROW_EXCEPTION(InternalCompilerError() << errinfo_comment("Storage size of non-storable type type requested.")); } virtual std::string toString() const override { return "type(" + m_actualType->toString() + ")"; } private: