From 7fe63e36e93775ec76665f1db07ed4341d5cb40c Mon Sep 17 00:00:00 2001 From: Liana Husikyan Date: Tue, 17 Mar 2015 10:48:46 +0100 Subject: [PATCH] changed the position of 'anonymous' keyword: event () anonymous. - style changes --- libsolidity/AST.h | 17 +++++++++++------ libsolidity/ExpressionCompiler.cpp | 2 +- libsolidity/Parser.cpp | 12 ++++++------ test/SolidityEndToEndTest.cpp | 2 +- 4 files changed, 19 insertions(+), 14 deletions(-) diff --git a/libsolidity/AST.h b/libsolidity/AST.h index c0ae3c164..5564d83db 100644 --- a/libsolidity/AST.h +++ b/libsolidity/AST.h @@ -553,12 +553,17 @@ private: class EventDefinition: public Declaration, public VariableScope, public Documented { public: - EventDefinition(SourceLocation const& _location, - ASTPointer const& _name, - ASTPointer const& _documentation, - ASTPointer const& _parameters, - bool _anonymous = false): - Declaration(_location, _name), Documented(_documentation), m_parameters(_parameters) , m_anonymous(_anonymous){} + EventDefinition( + SourceLocation const& _location, + ASTPointer const& _name, + ASTPointer const& _documentation, + ASTPointer const& _parameters, + bool _anonymous = false + ): + Declaration(_location, _name), + Documented(_documentation), + m_parameters(_parameters), + m_anonymous(_anonymous){} virtual void accept(ASTVisitor& _visitor) override; virtual void accept(ASTConstVisitor& _visitor) const override; diff --git a/libsolidity/ExpressionCompiler.cpp b/libsolidity/ExpressionCompiler.cpp index 99673edde..bff27e9c7 100644 --- a/libsolidity/ExpressionCompiler.cpp +++ b/libsolidity/ExpressionCompiler.cpp @@ -547,7 +547,7 @@ bool ExpressionCompiler::visit(FunctionCall const& _functionCall) m_context << u256(h256::Arith(dev::sha3(function.getCanonicalSignature(event.getName())))); ++numIndexed; } - solAssert(numIndexed <= 4 - (event.IsAnonymous() ? 1 : 0), "Too many indexed arguments."); + solAssert(numIndexed <= 4, "Too many indexed arguments."); // Copy all non-indexed arguments to memory (data) m_context << u256(0); for (unsigned arg = 0; arg < arguments.size(); ++arg) diff --git a/libsolidity/Parser.cpp b/libsolidity/Parser.cpp index 098a38344..393d2734e 100644 --- a/libsolidity/Parser.cpp +++ b/libsolidity/Parser.cpp @@ -388,18 +388,18 @@ ASTPointer Parser::parseEventDefinition() docstring = make_shared(m_scanner->getCurrentCommentLiteral()); expectToken(Token::Event); - bool anonymous = false; - if (m_scanner->getCurrentToken() == Token::Anonymous) - { - anonymous = true; - m_scanner->next(); - } ASTPointer name(expectIdentifierToken()); ASTPointer parameters; if (m_scanner->getCurrentToken() == Token::LParen) parameters = parseParameterList(true, true); else parameters = createEmptyParameterList(); + bool anonymous = false; + if (m_scanner->getCurrentToken() == Token::Anonymous) + { + anonymous = true; + m_scanner->next(); + } nodeFactory.markEndPosition(); expectToken(Token::Semicolon); return nodeFactory.createNode(name, docstring, parameters, anonymous); diff --git a/test/SolidityEndToEndTest.cpp b/test/SolidityEndToEndTest.cpp index 05d2e3af8..b42916ce6 100644 --- a/test/SolidityEndToEndTest.cpp +++ b/test/SolidityEndToEndTest.cpp @@ -2206,7 +2206,7 @@ BOOST_AUTO_TEST_CASE(event_anonymous) { char const* sourceCode = R"( contract ClientReceipt { - event anonymous Deposit(); + event Deposit() anonymous; function deposit() { Deposit(); }