From 07ecb2c1f29ea53ae99cf0aa42a56f87ad9f30a3 Mon Sep 17 00:00:00 2001
From: Lu Guanqun <guanqun.lu@gmail.com>
Date: Fri, 6 Feb 2015 07:44:38 +0800
Subject: [PATCH] disallow declaration of void type

https://www.pivotaltracker.com/n/projects/1189488/stories/86318578
---
 libsolidity/AST.cpp                    | 2 ++
 test/SolidityNameAndTypeResolution.cpp | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/libsolidity/AST.cpp b/libsolidity/AST.cpp
index dfb677f7e..0ec0eb0cc 100644
--- a/libsolidity/AST.cpp
+++ b/libsolidity/AST.cpp
@@ -383,6 +383,8 @@ void VariableDefinition::checkTypeRequirements()
 					BOOST_THROW_EXCEPTION(m_value->createTypeError("Invalid integer constant " + type->toString()));
 				type = intType;
 			}
+			else if (type->getCategory() == Type::Category::VOID)
+				BOOST_THROW_EXCEPTION(m_variable->createTypeError("var cannot be void type"));
 			m_variable->setType(type);
 		}
 	}
diff --git a/test/SolidityNameAndTypeResolution.cpp b/test/SolidityNameAndTypeResolution.cpp
index ae6c374b4..742d2ee2a 100644
--- a/test/SolidityNameAndTypeResolution.cpp
+++ b/test/SolidityNameAndTypeResolution.cpp
@@ -904,6 +904,12 @@ BOOST_AUTO_TEST_CASE(invalid_parameter_names_in_named_args)
 	BOOST_CHECK_THROW(parseTextAndResolveNames(sourceCode), TypeError);
 }
 
+BOOST_AUTO_TEST_CASE(disallow_declaration_of_void_type)
+{
+	char const* sourceCode = "contract c { function f() { var x = f(); } }";
+	BOOST_CHECK_THROW(parseTextAndResolveNames(sourceCode), TypeError);
+}
+
 BOOST_AUTO_TEST_SUITE_END()
 
 }