fixed potential race condition on DownloadMan destruction

10 years ago · b796e7238c
2 changed files with 4 additions and 0 deletions
--- a/libethereum/DownloadMan.cpp
+++ b/libethereum/DownloadMan.cpp
@ -44,6 +44,7 @@ DownloadSub::DownloadSub(DownloadMan& _man): m_man(&_man)

 DownloadSub::~DownloadSub()
 {
+	Guard fl(m_fetch);
 	if (m_man)
 	{
 		WriteGuard l(m_man->x_subs);
--- a/libethereum/DownloadMan.h
+++ b/libethereum/DownloadMan.h
@ -93,7 +93,10 @@ public:
 	~DownloadMan()
 	{
 		for (auto i: m_subs)
+		{
+			Guard l(i->m_fetch);
 			i->m_man = nullptr;
+		}
 	}

 	void appendToChain(h256s const& _hashes)