Code review. Fix inverted peer slot check.

libp2p/Host.cpp

@@ -226,7 +226,7 @@ void Host::startPeerSession(Public const& _id, RLP const& _rlp, RLPXFrameIO* _io
 					return;
 				}
 		
-		if (peerSlotsAvailable(Ingress))
+		if (!peerSlotsAvailable(Ingress))
 		{
 			ps->disconnect(TooManyPeers);
 			return;
@@ -580,10 +580,8 @@ void Host::run(boost::system::error_code const&)
 
 	// todo: update peerSlotsAvailable()
 	unsigned pendingCount = 0;
-	{
+	ETH_GUARDED(x_pendingNodeConns)
-		Guard l(x_pendingNodeConns);
 		pendingCount = m_pendingPeerConns.size();
-	}
 	int openSlots = m_idealPeerCount - peerCount() - pendingCount;
 	if (openSlots > 0)
 	{

libp2p/Host.h

@@ -162,7 +162,7 @@ protected:
 	void restoreNetwork(bytesConstRef _b);
 
 private:
-	enum PeerSlotRatio { Egress = 1, Ingress = 9 };
+	enum PeerSlotRatio { Egress = 2, Ingress = 9 };
 	
 	bool havePeerSession(NodeId _id) { RecursiveGuard l(x_sessions); return m_sessions.count(_id) ? !!m_sessions[_id].lock() : false; }
 	

libp2p/NodeTable.cpp

@@ -83,7 +83,7 @@ shared_ptr<NodeEntry> NodeTable::addNode(Public const& _pubk, NodeIPEndpoint con
 
 shared_ptr<NodeEntry> NodeTable::addNode(Node const& _node, NodeRelation _relation)
 {
-	if (_relation)
+	if (_relation == Known)
 	{
 		shared_ptr<NodeEntry> ret(new NodeEntry(m_node, _node.id, _node.endpoint));
 		ret->pending = false;