code review

libp2p/Host.cpp

@@ -176,11 +176,14 @@ unsigned Host::protocolVersion() const
 
 void Host::startPeerSession(Public const& _id, RLP const& _rlp, RLPXFrameIO* _io, bi::tcp::endpoint _endpoint)
 {
-	shared_ptr<Peer> p(new Peer());
+	shared_ptr<Peer> p;
-	if (m_peers.count(_id))
+	if (!m_peers.count(_id))
-		p = m_peers[_id];
+	{
-	else
+		p.reset(new Peer());
 		p->id = _id;
+	}
+	else
+		p = m_peers[_id];
 	p->m_lastDisconnect = NoDisconnect;
 	if (p->isOffline())
 		p->m_lastConnected = std::chrono::system_clock::now();

libp2p/NodeTable.cpp

@@ -309,7 +309,7 @@ void NodeTable::noteActiveNode(Public const& _pubk, bi::udp::endpoint const& _en
 			Guard l(x_state);
 			NodeBucket& s = bucket_UNSAFE(node.get());
 			bool removed = false;
-			s.nodes.remove_if([&node, &removed](weak_ptr<NodeEntry> n)
+			s.nodes.remove_if([&node, &removed](weak_ptr<NodeEntry> const& n)
 			{
 				if (n.lock() == node)
 					removed = true;