homebrew-versions

210 Commits

2 Branches

110 Tags

61 MiB

Tree: e0da11cac3

Commit Graph

Author	SHA1	Message	Date
Félix Saparelli	4de758bca3	Add tap support to `edit` and `list` Most notably, Cask.all returns an array of strings, not of Cask instances. This makes things easier, as well as faster, as there's no need to run map(&:to_s) everywhere anymore. self.path is a utility method which returns the path of the cask from its title. There's something subtle going in there: - If `cask_title` is fully qualified, e.g. "phinze-cask/alfred", it's straightforward. - If `cask_title` is only the name, e.g. "firefox-aurora", the name is matched from the full list (self.all) (which isn't sorted) and the first result is returned. Hence, self.path with only the name is not precise. There might be the possibility to apply heuristics to do a better match (prefer phinze-cask, or maybe installed casks?) but that's for another issue :-) self.nice_listing is another utility method used in `search` and `list`. It returns a list where unique casks don't have a prefix, and duplicates do. The prefix is the tap name. The list is then sorted. For an example or two, look at the first comment on phinze/#12.	13 years ago
phinze	b45974c224	support `brew cask edit`	13 years ago

Author

SHA1

Message

Date

Félix Saparelli

4de758bca3

Add tap support to `edit` and `list`

Most notably, Cask.all returns an array of strings,
not of Cask instances. This makes things easier, as
well as faster, as there's no need to run map(&:to_s)
everywhere anymore.

self.path is a utility method which returns the path
of the cask from its title. There's something subtle
going in there:

 - If `cask_title` is fully qualified, e.g.
   "phinze-cask/alfred", it's straightforward.

 - If `cask_title` is only the name, e.g.
   "firefox-aurora", the name is matched from
   the full list (self.all) (which isn't sorted)
   and the first result is returned.

Hence, self.path with only the name is not precise.
There might be the possibility to apply heuristics
to do a better match (prefer phinze-cask, or maybe
installed casks?) but that's for another issue :-)

self.nice_listing is another utility method used
in `search` and `list`. It returns a list where
unique casks don't have a prefix, and duplicates
do. The prefix is the tap name. The list is then
sorted. For an example or two, look at the first
comment on phinze/#12.

13 years ago

phinze

b45974c224

support `brew cask edit`

13 years ago

2 Commits (e0da11cac3b20666b9fbd421ee6d51f1c9bfa1c1)