Merge #904

904: Cleanup dependencies in `taker-frontend` r=thomaseizinger a=thomaseizinger

Read the commit messages for details.

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

.github/workflows/ci.yml

@@ -52,6 +52,7 @@ jobs:
       - run: yarn install
       - run: yarn run eslint
       - run: yarn run tsc
+      - run: yarn run npmPkgJsonLint .
 
   build_and_test_maker_frontend:
     defaults:

taker-frontend/package.json

@@ -16,20 +16,24 @@
     "@testing-library/jest-dom": "^5.16.1",
     "@testing-library/react": "^12.1.2",
     "@testing-library/user-event": "^13.5.0",
+    "@types/eslint": "^8.2.1",
     "@types/jest": "^27.0.3",
     "@types/node": "^16.11.12",
     "@types/react": "^17.0.37",
     "@types/react-dom": "^17.0.11",
     "@vitejs/plugin-react": "^1.1.3",
+    "@vitejs/plugin-react-refresh": "^1.3.1",
+    "eslint": "^8.4.1",
+    "eslint-config-react-app": "^7.0.0",
     "framer-motion": "^5",
     "next": "^12.0.4",
+    "npm-package-json-lint": "^5.4.2",
     "react": "^17.0.2",
     "react-async": "^10.0.1",
     "react-dom": "^17.0.2",
     "react-icons": "^4.3.1",
     "react-refresh": "^0.11.0",
     "react-router-dom": "6.1.1",
-    "react-scripts": "4.0.3",
     "react-sse-hooks": "^1.0.5",
     "react-use-websocket": "^2.9.1",
     "typescript": "^4.5.4",
@@ -40,13 +44,10 @@
     "about": "https://stackoverflow.com/a/45815391/2489334",
     "next": "We only installed next because there is a bug in @chakra-ui/react 1.7.2, see https://github.com/chakra-ui/chakra-ui/issues/5082"
   },
-  "devDependencies": {
-    "@types/eslint": "^8",
-    "@types/react": "^17.0.37",
-    "@types/react-dom": "^17.0.11",
-    "@vitejs/plugin-react-refresh": "^1.3.1",
-    "typescript": "^4.5.4",
-    "vite": "^2.7.2"
+  "npmpackagejsonlint": {
+    "rules": {
+      "prefer-no-devDependencies": "error"
+    }
   },
   "eslintConfig": {
     "parser": "@typescript-eslint/parser",