From 7355c339a69361b6ba4478f3cabc06c8e02be97d Mon Sep 17 00:00:00 2001
From: Daniel Karzel <daniel@comit.network>
Date: Fri, 15 Oct 2021 13:33:27 +1100
Subject: [PATCH] Remove todo in favour of warning for awareness

Better log a warning, the assumption is that we rarely see this. Let's see if that is true.
---
 daemon/src/maker_cfd.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/daemon/src/maker_cfd.rs b/daemon/src/maker_cfd.rs
index b74bec2..a6260ef 100644
--- a/daemon/src/maker_cfd.rs
+++ b/daemon/src/maker_cfd.rs
@@ -502,7 +502,13 @@ impl Actor {
                         command: TakerCommand::NotifyInvalidOrderId { id: order_id },
                     })
                     .await?;
-                // TODO: Return an error here?
+
+                // An outdated order on the taker side does not require any state change on the
+                // maker. notifying the taker with a specific message should be sufficient.
+                // Since this is a scenario that we should rarely see we log
+                // a warning to be sure we don't trigger this code path frequently.
+                tracing::warn!("Taker tried to take order with outdated id {}", order_id);
+
                 return Ok(());
             }
         };