Browse Source

Bundling does not require type-checking

Bundling the frontend does not necessarily require type checking,
nor should type checking imply bundling.

TSC is also fairly slow. Separate the two and invoke tsc separately in
CI.
fix-bad-api-calls
Thomas Eizinger 3 years ago
parent
commit
f265e01146
No known key found for this signature in database GPG Key ID: 651AC83A6C6C8B96
  1. 18
      .github/workflows/ci.yml
  2. 2
      frontend/package.json

18
.github/workflows/ci.yml

@ -28,7 +28,22 @@ jobs:
- uses: Swatinem/rust-cache@v1.3.0 - uses: Swatinem/rust-cache@v1.3.0
- run: cargo clippy --workspace --all-targets -- -D warnings - run: cargo clippy --workspace --all-targets -- -D warnings
build_frontend: check_frontend:
defaults:
run:
working-directory: frontend
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
cache: 'yarn'
cache-dependency-path: frontend/yarn.lock
- run: yarn install
- run: yarn run eslint
- run: yarn run tsc
build_and_test_frontend:
strategy: strategy:
matrix: matrix:
app: [ maker, taker ] app: [ maker, taker ]
@ -43,7 +58,6 @@ jobs:
cache: 'yarn' cache: 'yarn'
cache-dependency-path: frontend/yarn.lock cache-dependency-path: frontend/yarn.lock
- run: yarn install - run: yarn install
- run: yarn run eslint
- run: APP=${{ matrix.app }} yarn test - run: APP=${{ matrix.app }} yarn test
- run: APP=${{ matrix.app }} yarn build - run: APP=${{ matrix.app }} yarn build

2
frontend/package.json

@ -3,7 +3,7 @@
"version": "0.0.0", "version": "0.0.0",
"scripts": { "scripts": {
"dev": "vite", "dev": "vite",
"build": "tsc && vite build", "build": "vite build",
"serve": "vite preview", "serve": "vite preview",
"test": "vite-jest" "test": "vite-jest"
}, },

Loading…
Cancel
Save