555: Remove liquidation price from main screen. r=bonomat a=bonomat
The current shown liquidation price only makes sense if the trader goes long. If she were to go short, the liquidation price should be different. With the current setup we can't know whether the trader wants to go long or short, hence we can't show the correct liquidation price
resolve#547
Co-authored-by: bonomat <philipp@hoenisch.at>
552: Use a connection actor for the taker r=klochowicz a=klochowicz
Connection actor takes care of establishing a connection to the maker and is
monitoring its status.
The connection actor:
- listens for periodically sent heartbeat messages from the maker,
- publish the maker status on a watch::channel feed outside TakerActorSystem,
- observe changes on the watch channel and shut down Rocket if maker goes offline
Note: this is a stepping stone resulting in temporary behaviour. Eventually,
we'd want to support reconnecting to the maker as well as operating the
taker without the maker being online (with a limited set of actions).
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
554: Bump time from 0.3.4 to 0.3.5 r=thomaseizinger a=dependabot[bot]
Bumps [time](https://github.com/time-rs/time) from 0.3.4 to 0.3.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/time-rs/time/releases">time's releases</a>.</em></p>
<blockquote>
<h2>v0.3.5</h2>
<p>See the <a href="https://github.com/time-rs/time/blob/main/CHANGELOG.md">changelog</a> for details.</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/time-rs/time/blob/main/CHANGELOG.md">time's changelog</a>.</em></p>
<blockquote>
<h2>0.3.5 [2021-11-12]</h2>
<h3>Added</h3>
<ul>
<li><code>Date::checked_add</code></li>
<li><code>Date::checked_sub</code></li>
<li><code>PrimitiveDateTime::checked_add</code></li>
<li><code>PrimitiveDateTime::checked_sub</code></li>
<li><code>OffsetDateTime::checked_add</code></li>
<li><code>OffsetDateTime::checked_sub</code></li>
</ul>
<h3>Changed</h3>
<ul>
<li>Attempts to obtain the local UTC offset will now succeed on Linux if the process is
single-threaded. This does not affect other Unix platforms. As a reminder, the relevant methods
are fallible and may return an <code>Err</code> value for any reason.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="6b8cdd3d9e"><code>6b8cdd3</code></a> v0.3.5 release</li>
<li><a href="77f8bfa8b0"><code>77f8bfa</code></a> Re-enable obtaining local offset on Linux</li>
<li><a href="a2b67af397"><code>a2b67af</code></a> Move local offset function to proper sys directory</li>
<li><a href="fff7f80847"><code>fff7f80</code></a> Add example to rfc3339's docs (<a href="https://github-redirect.dependabot.com/time-rs/time/issues/391">#391</a>)</li>
<li><a href="bca24a9ca7"><code>bca24a9</code></a> Remove leading empty lines in doctests</li>
<li><a href="6b9f03f846"><code>6b9f03f</code></a> Fix <code>OffsetDateTime::checked_{add,sub}</code> implementations (<a href="https://github-redirect.dependabot.com/time-rs/time/issues/386">#386</a>)</li>
<li><a href="ffb20c0bf2"><code>ffb20c0</code></a> Fix auto-release on tag push</li>
<li><a href="a6fedb0153"><code>a6fedb0</code></a> Formatting</li>
<li><a href="86942f5a33"><code>86942f5</code></a> Only build benchmark dependencies when necessary</li>
<li><a href="10b8c5c68c"><code>10b8c5c</code></a> Update feature gates to mirror latest nightly</li>
<li>Additional commits viewable in <a href="https://github.com/time-rs/time/compare/v0.3.4...v0.3.5">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Connection actor takes care of establishing a connection to the maker and is
monitoring its status.
The connection actor:
- listens for periodically sent heartbeat messages from the maker,
- publish the maker status on a watch::channel feed outside TakerActorSystem,
- observe changes on the watch channel and shut down Rocket if maker goes offline
Note: this is a stepping stone resulting in temporary behaviour. Eventually,
we'd want to support reconnecting to the maker as well as operating the
taker without the maker being online (with a limited set of actions).
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
489: Bump serde_json from 1.0.68 to 1.0.69 r=thomaseizinger a=dependabot[bot]
Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.68 to 1.0.69.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/serde-rs/json/releases">serde_json's releases</a>.</em></p>
<blockquote>
<h2>v1.0.69</h2>
<ul>
<li>Implement Hash for serde_json::Number (<a href="https://github-redirect.dependabot.com/serde-rs/json/issues/814">#814</a>, thanks <a href="https://github.com/timothee-haudebourg"><code>`@timothee-haudebourg</code></a>)</li>`
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5c4f8b2254"><code>5c4f8b2</code></a> Release 1.0.69</li>
<li><a href="0035947522"><code>0035947</code></a> Touch up PR 814</li>
<li><a href="a28b1b1934"><code>a28b1b1</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/serde-rs/json/issues/814">#814</a> from timothee-haudebourg/hash-numbers-only</li>
<li><a href="f53ae31df6"><code>f53ae31</code></a> Use the same hash for +0 and -0.</li>
<li><a href="8b35517540"><code>8b35517</code></a> Revert "Disable broken fuzz build in CI"</li>
<li><a href="d12fbb9520"><code>d12fbb9</code></a> Fix <code>NaN</code> typo.</li>
<li><a href="48393aba40"><code>48393ab</code></a> Better justification for the use of <code>f64::to_bits</code></li>
<li><a href="9046e3fa86"><code>9046e3f</code></a> Avoid <code>Self::</code> for older Rust versions.</li>
<li><a href="c3ac6c0077"><code>c3ac6c0</code></a> Manual implementation of <code>Number</code>'s <code>PartialEq</code>.</li>
<li><a href="10655c7639"><code>10655c7</code></a> Use <code>core::hash</code> instead of <code>std::hash</code>.</li>
<li>Additional commits viewable in <a href="https://github.com/serde-rs/json/compare/v1.0.68...v1.0.69">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
544: Use fewer payouts in the tests r=thomaseizinger a=thomaseizinger
This makes our test run fast by default without the need for a feature flag.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
The current shown liquidation price only makes sense if the trader goes long. If she were to go short, the liquidation price should be different. With the current setup we can't know whether the trader wants to go long or short, hence we can't show the correct liquidation price
551: Configurable log levels on both taker and maker r=da-kami a=da-kami
Add configurable log levels on taker and maker and start tracing connection related information to track down a problem where the taker does not receive orders but there are not connection errors on both sides.
https://github.com/itchysats/itchysats/issues/550
Co-authored-by: Daniel Karzel <daniel@comit.network>
Add configurable log levels on taker and maker and start tracing connection related information to track down a problem where the taker does not receive orders but there are not connection errors on both sides.
545: Disable taker's "go long" button under the same conditions as older UI r=da-kami a=klochowicz
Disable the button when there's no order or there's an in-flight order request
already.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
514: Publish docker image improvements r=itchymax a=itchymax
Note: the only thing we need from the checkout is the dockerfile. The rest does not matter.
Nevertheless, when manually releasing docker images by release tag, we should check out that particular release tag to ensure we are using the correct dockerfile
Co-authored-by: itchymax <itchymax@itchysats.network>
532: Taker handles order received from maker already known r=da-kami a=da-kami
fixes https://github.com/itchysats/itchysats/issues/526
In case we already have a cfd for the received order we bail, because that should not happen.
If we already know the order, but don't have a related cfd we don't insert but still send it out on the order feed.
Co-authored-by: Daniel Karzel <daniel@comit.network>
531: Cleanup frontend code r=klochowicz a=klochowicz
Remove the `APP` variable from `maker-frontend` (from now on, it only builds maker).
Update README, CI and start_all.sh script.
note: the old taker component will be remove in the next PR, as I'm still mining it for ideas.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
In case we already have a cfd for the received order we bail, because that should not happen.
If we already know the order, but don't have a related cfd we don't insert but still send it out on the order feed.
We should remove the order as soon as we know that we will create a cfd out of it.
The (automated) maker reacts on the state change on the feed and may trigger creating a new order.
If we only remove the order at the end the `None` might arrive at the taker after we send the new order.
Furthermore, we should always remove the order independent of accept/reject, so this is done only once upon handling the take request now.
Note that due to this async nature of the application it can still happen that the taker receives `None` after the new `Some(order)`, but this behaviour becomes less likely and the code is generally more correct.
We could also make sending the message to the taker sync, but that might have unwanted, long-blocking side effects.
528: Mock common empty handlers at test actor system startup r=klochowicz a=klochowicz
These empty handlers are needed in most tests, otherwise a test can fail if a
message is sent from an actor to a non-existent inbox.
I noticed that the contract setup test failed on the CI recently due to the
monitor oracle attestation msg not being mocked.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
527: Generate seed automatically if no seed is present r=klochowicz a=klochowicz
Smooth out user experience by automatically generating a new seed if there
is none present (and by writing that fact in the log file).
Fixes#505
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
523: Use `send` instead of `do_send` in actor tests r=klochowicz a=klochowicz
`do_send` did not inspect any errors, while Cfd actors support returning errors
if an action performed on them failed.
This matches the code used in production in HTTP requests.
Slight changes in the test were required as the test failed
otherwise (particularly, on unhandled monitoring of oracle attestation).
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
`do_send` did not inspect any errors, while Cfd actors support returning errors
if an action performed on them failed.
This matches the code used in production in HTTP requests.
Slight changes in the test were required as the test failed
otherwise (particularly, on unhandled monitoring of oracle attestation).
511: Test cleanup r=klochowicz a=klochowicz
A small refactor, hopefully reducing entry barrier in creating new tests.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
Daniel Karzel
bors[bot]
Mariusz Klochowicz
bonomat
dependabot[bot]
Thomas Eizinger
itchymax
