380: Treat `InvalidOrderId` from maker as `Rejected` r=luckysori a=luckysori
If the maker tells the taker that the take request was for an invalid order ID, we should do something other than panic. For example,
logging and treating the situation as if the maker had rejected the take request.
Co-authored-by: Lucas Soriano del Pino <l.soriano.del.pino@gmail.com>
If the maker tells the taker that the take request was for an invalid
order ID, we should do something other than panic. For example,
logging and treating the situation as if the maker had rejected the
take request.
374: Validate sqlx insertions r=klochowicz a=klochowicz
Validate the insertions & add a new test to check cfd feed contents
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
372: Print git tag when starting maker/taker r=bonomat a=bonomat
Prints this on latest master:
```bash
2021-10-19 09:08:22 INFO Running version: preview-133-ga998367
```
Co-authored-by: Philipp Hoenisch <philipp@hoenisch.at>
367: Remove pending roll over proposal upon rejection r=da-kami a=da-kami
fixes#359
too me a bit to figure out how easy the fix is 😅
Co-authored-by: Daniel Karzel <daniel@comit.network>
356: Add timeout to contract-setup r=thomaseizinger a=thomaseizinger
- Remove stale TODO
- Add log statements to sections of contract-setup
- Add timeouts to awaiting messages during contract setup
- Fix typo
- Add timeouts to rollover messages
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
347: Maker actor system r=luckysori a=luckysori
How does this attempt at an actor system look?
- The constructor just hooks everything up in the same way that `main` currently does. I think we want this to be consistent between tests and production.
- The closures allow us to build whatever actors we want so long as they respect the contract expressed in the trait bounds. Maybe this is clunky. This could be leveraged to, for example, construct a `monitor::Actor` stand-in which immediately finds any transactions we subscribe to.
- I assume both the `wallet` and `db` arguments can be previously initialised for the purpose of testing, like we've done in the past.
363: Add log statement for completed roll over r=da-kami a=thomaseizinger
Co-authored-by: Lucas Soriano del Pino <l.soriano.del.pino@gmail.com>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
353: Make `taker_cfd::Actor` generic over other actor addresses r=luckysori a=luckysori
Equivalent to what we did to `maker_cfd::Actor` in #339.
Co-authored-by: Lucas Soriano del Pino <l.soriano.del.pino@gmail.com>
355: Notify monitor actor to watch for collaborative close tx r=da-kami a=da-kami
So far we only did this on startup, but not during the actual execution of the collaborative close.
Co-authored-by: Daniel Karzel <daniel@comit.network>
338: Refactor database queries, take #2 r=thomaseizinger a=thomaseizinger
Fix up SQL queries
This PR does a few things:
* cleans up the SQL to make the queries clearer in terms of intent, as well as eliminating the use of an extra transaction in some write queries.
* adds some additional testing
* (mostly) eliminates the use of `serde_json::to_string()`, making the data columns behave in a more sane manner
351: Sync with Olivia every 5 seconds r=thomaseizinger a=thomaseizinger
We are only making requests to Olivia that are absolutely necessary,
i.e. only fetch attestations when they are likely ready and only
fetch attestations that we definitely need.
As a result, we can trigger the sync much more frequent.
Fixes#349.
Co-authored-by: DelicioiusHair <mshepit@gmail.com>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
328: Bump secp256k1-zkp from `0dba4c0` to `ab7f6d8` r=thomaseizinger a=dependabot[bot]
Bumps [secp256k1-zkp](https://github.com/ElementsProject/rust-secp256k1-zkp) from `0dba4c0` to `ab7f6d8`.
<details>
<summary>Commits</summary>
<ul>
<li><a href="ab7f6d8f5e"><code>ab7f6d8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/ElementsProject/rust-secp256k1-zkp/issues/36">#36</a> from stevenroose/whitelist</li>
<li><a href="9144faa929"><code>9144faa</code></a> Add whitelist support</li>
<li>See full diff in <a href="0dba4c033a...ab7f6d8f5e74fd7bf5348d4fc3593bcc1dd532ad">compare view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR does a few things:
* cleans up the SQL to make the queries clearer in terms of intent, as well as eliminating the use of an extra transaction in some write queries.
* adds some additional testing
* (mostly) eliminates the use of `serde_json::to_string()`, making the data columns behave in a more sane manner
344: Move key to the toplevel child hierarchy elem r=da-kami a=da-kami
Got the complaint that `each child needs to have unique key` (Firefox) because the key was not on the child, but on a nested item.
Co-authored-by: Daniel Karzel <daniel@comit.network>
339: Make `maker_cfd::Actor` generic over other actor addresses r=luckysori a=luckysori
The diff is gonna be hard to review because I had to reorganise all the methods in separate `impl` blocks so that we only require the necessary trait bounds across the board.
Co-authored-by: Lucas Soriano del Pino <l.soriano.del.pino@gmail.com>
We are only making requests to Olivia that are absolutely necessary,
i.e. only fetch attestations when they are likely ready and only
fetch attestations that we definitely need.
As a result, we can trigger the sync much more frequent.
Fixes#349.
343: All tooltips to action icons in CfdTable r=klochowicz a=klochowicz
It makes it a bit easier to use, especially for newcomers
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
342: Display available quantity in the taker r=klochowicz a=klochowicz
It becomes important when someone else controls the offers from the maker.
This should be enough for now, but it would be nice to provide nicer validation field at some point.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
340: No reachable panics r=thomaseizinger a=thomaseizinger
- Don't return plain-text errors to the user
- Don't expose panicking code paths to the user
341: Taker routes channels r=luckysori a=luckysori
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Lucas Soriano del Pino <l.soriano.del.pino@gmail.com>
337: Better DB tests and various cleanups r=thomaseizinger a=thomaseizinger
- Extend DB test suite
- Directly return `PoolConnection`
- Don't use Default for test instance
- Take `Cfd` by reference if we don't need to consume it
- Use pretty assertions
- Make DB tests more readable by reducing boilerplate
- Refactor `insert_new_cfd_state_by_order_id` to `append_cfd_state`
- Reduce boilerplate in constructing `CfdStateCommon`
- Make it less verbose to construct simple states
- Add test for a variety of state updates
- Run tests against in-memory DB
Co-authored-by: Daniel Karzel <daniel@comit.network>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Thomas Eizinger
bors[bot]
Lucas Soriano del Pino
Mariusz Klochowicz
Philipp Hoenisch
dependabot[bot]
Daniel Karzel
DelicioiusHair