531: Cleanup frontend code r=klochowicz a=klochowicz
Remove the `APP` variable from `maker-frontend` (from now on, it only builds maker).
Update README, CI and start_all.sh script.
note: the old taker component will be remove in the next PR, as I'm still mining it for ideas.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
In case we already have a cfd for the received order we bail, because that should not happen.
If we already know the order, but don't have a related cfd we don't insert but still send it out on the order feed.
We should remove the order as soon as we know that we will create a cfd out of it.
The (automated) maker reacts on the state change on the feed and may trigger creating a new order.
If we only remove the order at the end the `None` might arrive at the taker after we send the new order.
Furthermore, we should always remove the order independent of accept/reject, so this is done only once upon handling the take request now.
Note that due to this async nature of the application it can still happen that the taker receives `None` after the new `Some(order)`, but this behaviour becomes less likely and the code is generally more correct.
We could also make sending the message to the taker sync, but that might have unwanted, long-blocking side effects.
528: Mock common empty handlers at test actor system startup r=klochowicz a=klochowicz
These empty handlers are needed in most tests, otherwise a test can fail if a
message is sent from an actor to a non-existent inbox.
I noticed that the contract setup test failed on the CI recently due to the
monitor oracle attestation msg not being mocked.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
527: Generate seed automatically if no seed is present r=klochowicz a=klochowicz
Smooth out user experience by automatically generating a new seed if there
is none present (and by writing that fact in the log file).
Fixes#505
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
523: Use `send` instead of `do_send` in actor tests r=klochowicz a=klochowicz
`do_send` did not inspect any errors, while Cfd actors support returning errors
if an action performed on them failed.
This matches the code used in production in HTTP requests.
Slight changes in the test were required as the test failed
otherwise (particularly, on unhandled monitoring of oracle attestation).
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
`do_send` did not inspect any errors, while Cfd actors support returning errors
if an action performed on them failed.
This matches the code used in production in HTTP requests.
Slight changes in the test were required as the test failed
otherwise (particularly, on unhandled monitoring of oracle attestation).
511: Test cleanup r=klochowicz a=klochowicz
A small refactor, hopefully reducing entry barrier in creating new tests.
Co-authored-by: Mariusz Klochowicz <mariusz@klochowicz.com>
495: Release version 0.1.1 r=itchymax a=itchymax
Hi `@itchymax!`
This PR was created in response to a manual trigger of the release workflow here: https://github.com/itchysats/itchysats/actions/runs/1438605510.
I've bumped the versions in the manifest files in this commit: c3fc1ca871.
Merging this PR will create a GitHub release and publish the library to crates.io!
Co-authored-by: itchymax <itchymax@protonmail.com>
itchymax
bors[bot]
Mariusz Klochowicz
Daniel Karzel
Thomas Eizinger
dependabot[bot]
bonomat
scratchy
Itchy Max