Browse Source

Merge pull request #726 from meriadec/cursor-sidebar

Cursor `not-allowed` on disabled sidebar items
master
Meriadec Pillet 7 years ago
committed by GitHub
parent
commit
879e9feb13
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 5
      src/components/base/SideBar/SideBarListItem.js

5
src/components/base/SideBar/SideBarListItem.js

@ -33,7 +33,7 @@ class SideBarListItem extends PureComponent<Props> {
<Container
isActive={!disabled && isActive}
iconActiveColor={iconActiveColor}
onClick={disabled ? null : onClick}
onClick={disabled ? undefined : onClick}
disabled={disabled}
>
{!!Icon && <Icon size={16} />}
@ -62,8 +62,7 @@ const Container = styled(Tabbable).attrs({
px: 3,
py: 2,
})`
cursor: ${p => (p.disabled || p.isActive ? 'default' : 'pointer')};
pointer-events: ${p => (p.isDisabled ? 'none' : 'auto')};
cursor: ${p => (p.disabled ? 'not-allowed' : p.isActive ? 'default' : 'pointer')};
color: ${p => (p.isActive ? p.theme.colors.dark : p.theme.colors.smoke)};
background: ${p => (p.isActive ? p.theme.colors.lightGrey : '')};
opacity: ${p => (p.disabled ? 0.5 : 1)};

Loading…
Cancel
Save