From f52dd6c747f04a731381eac088c5051b01d1e918 Mon Sep 17 00:00:00 2001
From: meriadec <meriadec.pillet@gmail.com>
Date: Wed, 14 Feb 2018 14:09:28 +0100
Subject: [PATCH 1/2] Speed up accounts order dropdown by caching value

---
 src/components/DashboardPage/AccountsOrder.js | 100 ++++++++++++++++++
 src/components/DashboardPage/index.js         |  48 +--------
 2 files changed, 104 insertions(+), 44 deletions(-)
 create mode 100644 src/components/DashboardPage/AccountsOrder.js

diff --git a/src/components/DashboardPage/AccountsOrder.js b/src/components/DashboardPage/AccountsOrder.js
new file mode 100644
index 00000000..4d6b3e5b
--- /dev/null
+++ b/src/components/DashboardPage/AccountsOrder.js
@@ -0,0 +1,100 @@
+// @flow
+
+import React, { Component } from 'react'
+import { compose } from 'redux'
+import { translate } from 'react-i18next'
+import { connect } from 'react-redux'
+
+import type { MapStateToProps } from 'react-redux'
+
+import type { T } from 'types/common'
+
+import { getOrderAccounts } from 'reducers/settings'
+
+import { updateOrderAccounts } from 'actions/accounts'
+import { saveSettings } from 'actions/settings'
+
+import Box from 'components/base/Box'
+import DropDown from 'components/base/DropDown'
+import Text from 'components/base/Text'
+import IconAngleDown from 'icons/AngleDown'
+
+const mapStateToProps: MapStateToProps<*, *, *> = state => ({
+  orderAccounts: getOrderAccounts(state),
+})
+
+const mapDispatchToProps = {
+  updateOrderAccounts,
+  saveSettings,
+}
+
+type Props = {
+  t: T,
+  orderAccounts: string,
+  updateOrderAccounts: Function,
+  saveSettings: Function,
+}
+
+type State = {
+  cachedValue: string | null,
+}
+
+class AccountsOrder extends Component<Props, State> {
+  state = {
+    cachedValue: null,
+  }
+
+  componentWillMount() {
+    this.setState({ cachedValue: this.props.orderAccounts })
+  }
+
+  setAccountOrder = order => {
+    const { updateOrderAccounts, saveSettings } = this.props
+    this.setState({ cachedValue: order }, () => {
+      window.requestIdleCallback(() => {
+        updateOrderAccounts(order)
+        saveSettings({ orderAccounts: order })
+      })
+    })
+  }
+
+  render() {
+    const { t } = this.props
+    const { cachedValue } = this.state
+
+    if (!cachedValue) {
+      return null
+    }
+
+    const sortItems = [
+      {
+        key: 'name',
+        label: t('orderAccounts.name'),
+      },
+      {
+        key: 'balance',
+        label: t('orderAccounts.balance'),
+      },
+      {
+        key: 'type',
+        label: t('orderAccounts.type'),
+      },
+    ]
+
+    return (
+      <DropDown
+        onChange={item => this.setAccountOrder(item.key)}
+        items={sortItems}
+        ff="Open Sans|SemiBold"
+        fontSize={4}
+      >
+        <Box horizontal align="center" flow={1} color="dark">
+          <Text color="dark">{t(`orderAccounts.${cachedValue}`)}</Text>
+          <IconAngleDown height={7} width={8} />
+        </Box>
+      </DropDown>
+    )
+  }
+}
+
+export default compose(connect(mapStateToProps, mapDispatchToProps), translate())(AccountsOrder)
diff --git a/src/components/DashboardPage/index.js b/src/components/DashboardPage/index.js
index 31465fd4..3e4dedfe 100644
--- a/src/components/DashboardPage/index.js
+++ b/src/components/DashboardPage/index.js
@@ -13,12 +13,11 @@ import sortBy from 'lodash/sortBy'
 import takeRight from 'lodash/takeRight'
 
 import type { MapStateToProps } from 'react-redux'
-import type { Accounts, T } from 'types/common'
+import type { Accounts } from 'types/common'
 
 import { space } from 'styles/theme'
 
 import { getVisibleAccounts } from 'reducers/accounts'
-import { getOrderAccounts } from 'reducers/settings'
 
 import { updateOrderAccounts } from 'actions/accounts'
 import { saveSettings } from 'actions/settings'
@@ -28,16 +27,13 @@ import Box, { Card } from 'components/base/Box'
 import Pills from 'components/base/Pills'
 import Text from 'components/base/Text'
 import TransactionsList from 'components/TransactionsList'
-import DropDown from 'components/base/DropDown'
-
-import IconAngleDown from 'icons/AngleDown'
 
 import AccountCard from './AccountCard'
 import BalanceInfos from './BalanceInfos'
+import AccountsOrder from './AccountsOrder'
 
 const mapStateToProps: MapStateToProps<*, *, *> = state => ({
   accounts: getVisibleAccounts(state),
-  orderAccounts: getOrderAccounts(state),
 })
 
 const mapDispatchToProps = {
@@ -49,10 +45,6 @@ const mapDispatchToProps = {
 type Props = {
   accounts: Accounts,
   push: Function,
-  t: T,
-  updateOrderAccounts: Function,
-  saveSettings: Function,
-  orderAccounts: string,
 }
 
 type State = {
@@ -136,12 +128,6 @@ class DashboardPage extends PureComponent<Props, State> {
     return chunk(listAccounts, ACCOUNTS_BY_LINE)
   }
 
-  setAccountOrder = order => {
-    const { updateOrderAccounts, saveSettings } = this.props
-    updateOrderAccounts(order)
-    saveSettings({ orderAccounts: order })
-  }
-
   addFakeDatasOnAccounts = () => {
     const { accounts } = this.props
 
@@ -167,26 +153,11 @@ class DashboardPage extends PureComponent<Props, State> {
   _timeout = undefined
 
   render() {
-    const { push, accounts, t, orderAccounts } = this.props
+    const { push, accounts } = this.props
     const { selectedTime, fakeDatas } = this.state
 
     const totalAccounts = accounts.length
 
-    const sortItems = [
-      {
-        key: 'name',
-        label: t('orderAccounts.name'),
-      },
-      {
-        key: 'balance',
-        label: t('orderAccounts.balance'),
-      },
-      {
-        key: 'type',
-        label: t('orderAccounts.type'),
-      },
-    ]
-
     return (
       <Box flow={7}>
         <Box horizontal align="flex-end">
@@ -249,18 +220,7 @@ class DashboardPage extends PureComponent<Props, State> {
                   <Text ff="Open Sans|SemiBold" fontSize={4}>
                     {'Sort by'}
                   </Text>
-                  <DropDown
-                    onChange={item => this.setAccountOrder(item.key)}
-                    items={sortItems}
-                    ff="Open Sans|SemiBold"
-                    fontSize={4}
-                    value={sortItems.find(s => s.key === orderAccounts)}
-                  >
-                    <Box horizontal align="center" flow={1} color="dark">
-                      <Text>{t(`orderAccounts.${orderAccounts}`)}</Text>
-                      <IconAngleDown height={7} width={8} />
-                    </Box>
-                  </DropDown>
+                  <AccountsOrder />
                 </Box>
               </Box>
               <Box flow={5}>

From 5ba9ed44f7251faabfdb8e79c8345e22f634afe0 Mon Sep 17 00:00:00 2001
From: meriadec <meriadec.pillet@gmail.com>
Date: Wed, 14 Feb 2018 14:48:54 +0100
Subject: [PATCH 2/2] Fix font sizes and padding on various places

---
 src/components/AccountPage.js             | 49 ++++++++++-------------
 src/components/Breadcrumb/index.js        |  3 +-
 src/components/SettingsPage/Profile.js    |  2 +-
 src/components/SettingsPage/index.js      |  4 +-
 src/components/base/Button/index.js       |  2 +-
 src/components/base/Label.js              |  2 +-
 src/components/base/Modal/index.js        |  8 ++--
 src/components/base/Tabs/index.js         |  2 +-
 src/components/modals/AddAccount/index.js |  2 +-
 src/components/modals/Send.js             |  4 +-
 10 files changed, 37 insertions(+), 41 deletions(-)

diff --git a/src/components/AccountPage.js b/src/components/AccountPage.js
index 31fb102b..6158c4b8 100644
--- a/src/components/AccountPage.js
+++ b/src/components/AccountPage.js
@@ -52,36 +52,31 @@ class AccountPage extends PureComponent<Props> {
       <Box flow={3}>
         <Box horizontal>
           <Box>
-            <Text fontSize={4}>{account.name}</Text>
+            <Text fontSize={8}>{account.name}</Text>
           </Box>
-          <Box horizontal align="center" justify="flex-end" grow flow={20}>
-            <Box>
-              <Button primary onClick={() => openModal(MODAL_SEND, { account })}>
-                <Box horizontal flow={2} align="center">
-                  <Box>
-                    <Icon name="upload" />
-                  </Box>
-                  <Box>{t('send.title')}</Box>
+          <Box horizontal align="center" justify="flex-end" grow flow={2}>
+            <Button primary onClick={() => openModal(MODAL_SEND, { account })}>
+              <Box horizontal flow={2} align="center">
+                <Box>
+                  <Icon name="upload" />
                 </Box>
-              </Button>
-            </Box>
-            <Box>
-              <Button primary onClick={() => openModal(MODAL_RECEIVE, { account })}>
-                <Box horizontal flow={2} align="center">
-                  <Box>
-                    <Icon name="download" />
-                  </Box>
-                  <Box>{t('receive.title')}</Box>
+                <Box>{t('send.title')}</Box>
+              </Box>
+            </Button>
+            <Button primary onClick={() => openModal(MODAL_RECEIVE, { account })}>
+              <Box horizontal flow={2} align="center">
+                <Box>
+                  <Icon name="download" />
                 </Box>
-              </Button>
-            </Box>
-            <Box>
-              <Button
-                icon="sliders-h"
-                color="mouse"
-                onClick={() => openModal(MODAL_SETTINGS_ACCOUNT, { account })}
-              />
-            </Box>
+                <Box>{t('receive.title')}</Box>
+              </Box>
+            </Button>
+            <Button
+              style={{ width: 50 }}
+              icon="sliders-h"
+              color="mouse"
+              onClick={() => openModal(MODAL_SETTINGS_ACCOUNT, { account })}
+            />
           </Box>
         </Box>
         {accountData && (
diff --git a/src/components/Breadcrumb/index.js b/src/components/Breadcrumb/index.js
index 794f3dbe..216fe4a2 100644
--- a/src/components/Breadcrumb/index.js
+++ b/src/components/Breadcrumb/index.js
@@ -10,6 +10,7 @@ const BreadcrumbWrapper = styled(Box).attrs({
   align: 'center',
   relative: true,
 })``
+
 const BreadcrumbStep = styled(({ start, active, end, ...props }) => (
   <Box start={start} end={end} active={active} {...props} />
 )).attrs({
@@ -84,7 +85,7 @@ const Breadcrumb = ({ items, currentStep }: Props) => (
             <BreadcrumbNumberWrapper>
               <BreadcrumbNumber active={active}>{i + 1}</BreadcrumbNumber>
             </BreadcrumbNumberWrapper>
-            <Box fontSize={0}>{item.label}</Box>
+            <Box fontSize={3}>{item.label}</Box>
           </BreadcrumbStep>
         </Fragment>
       )
diff --git a/src/components/SettingsPage/Profile.js b/src/components/SettingsPage/Profile.js
index 41e97c18..1545492c 100644
--- a/src/components/SettingsPage/Profile.js
+++ b/src/components/SettingsPage/Profile.js
@@ -90,7 +90,7 @@ class TabProfile extends PureComponent<Props, State> {
             <Box
               horizontal
               align="center"
-              flow={1}
+              flow={2}
               style={{ cursor: 'pointer' }}
               onClick={() => this.handleChangeInput('password.state')(!isPasswordChecked)}
             >
diff --git a/src/components/SettingsPage/index.js b/src/components/SettingsPage/index.js
index e3d6a9ce..740ad75d 100644
--- a/src/components/SettingsPage/index.js
+++ b/src/components/SettingsPage/index.js
@@ -64,8 +64,8 @@ class SettingsPage extends PureComponent<Props, State> {
     }
 
     return (
-      <Box flow={4}>
-        <Text fontSize={5}>{t('settings.title')}</Text>
+      <Box flow={6}>
+        <Text fontSize={7}>{t('settings.title')}</Text>
         <Tabs
           index={tab}
           onTabClick={this.handleChangeTab}
diff --git a/src/components/base/Button/index.js b/src/components/base/Button/index.js
index 0cd5d5ad..e0889ad6 100644
--- a/src/components/base/Button/index.js
+++ b/src/components/base/Button/index.js
@@ -41,7 +41,7 @@ function getProps({ disabled, icon, primary }: Object) {
         px: 1,
       },
       {
-        fontSize: 1,
+        fontSize: 4,
         px: 3,
       },
     ),
diff --git a/src/components/base/Label.js b/src/components/base/Label.js
index 38203370..1d4811fd 100644
--- a/src/components/base/Label.js
+++ b/src/components/base/Label.js
@@ -2,7 +2,7 @@ import styled from 'styled-components'
 import { fontSize } from 'styled-system'
 
 export default styled.label.attrs({
-  fontSize: 0,
+  fontSize: 3,
 })`
   ${fontSize};
   display: block;
diff --git a/src/components/base/Modal/index.js b/src/components/base/Modal/index.js
index 3c1e19cf..152ca7e5 100644
--- a/src/components/base/Modal/index.js
+++ b/src/components/base/Modal/index.js
@@ -72,7 +72,7 @@ const Backdrop = styled(Box).attrs({
 
 const Wrapper = styled(Tabbable).attrs({
   bg: 'transparent',
-  flow: 20,
+  flow: 4,
   mt: 100,
   mb: 100,
   style: p => ({
@@ -93,7 +93,7 @@ const Body = styled(Box).attrs({
 `
 
 const CloseContainer = styled(Box).attrs({
-  p: 2,
+  p: 4,
   color: 'mouse',
 })`
   cursor: pointer;
@@ -214,10 +214,10 @@ export const ModalBody = ({
   <Body>
     {onClose && (
       <CloseContainer onClick={onClose}>
-        <Icon fontSize={3} name="times" />
+        <Icon fontSize={6} name="times" />
       </CloseContainer>
     )}
-    <Box p={3} {...props}>
+    <Box p={5} {...props}>
       {children}
     </Box>
   </Body>
diff --git a/src/components/base/Tabs/index.js b/src/components/base/Tabs/index.js
index 2d257506..eeed319f 100644
--- a/src/components/base/Tabs/index.js
+++ b/src/components/base/Tabs/index.js
@@ -12,7 +12,7 @@ const Tab = styled(Tabbable).attrs({
   pb: 2,
   align: 'center',
   justify: 'center',
-  fontSize: 1,
+  fontSize: 3,
 })`
   border-bottom: 2px solid transparent;
   border-bottom-color: ${p => (p.isActive ? p.theme.colors.blue : '')};
diff --git a/src/components/modals/AddAccount/index.js b/src/components/modals/AddAccount/index.js
index d34c3cab..e858438a 100644
--- a/src/components/modals/AddAccount/index.js
+++ b/src/components/modals/AddAccount/index.js
@@ -304,7 +304,7 @@ class AddAccountModal extends PureComponent<Props, State> {
 
           return (
             <ModalBody onClose={onClose} flow={3}>
-              <Text fontSize={4} color="steel">
+              <Text fontSize={6} color="steel">
                 {t('addAccount.title')}
               </Text>
               <Step {...this.getStepProps()} />
diff --git a/src/components/modals/Send.js b/src/components/modals/Send.js
index 6e5f9579..f1aeeece 100644
--- a/src/components/modals/Send.js
+++ b/src/components/modals/Send.js
@@ -30,7 +30,7 @@ const Steps = {
       }}
     >
       <Box flow={3}>
-        <Text fontSize={4} color="steel">
+        <Text fontSize={6} color="steel">
           {t('send.title')}
         </Text>
         <Box flow={1}>
@@ -157,7 +157,7 @@ class Send extends PureComponent<Props, State> {
 
           return (
             <Fragment>
-              <ModalBody p={2}>
+              <ModalBody p={3}>
                 <Breadcrumb
                   currentStep={step}
                   items={[