From 3626489e8090f46d2247bf6db10919ad472cda6f Mon Sep 17 00:00:00 2001 From: Anastasia Poupeney Date: Fri, 29 Jun 2018 12:26:12 +0200 Subject: [PATCH 1/2] fix double opening of external links and changing empty account tile image --- src/components/DashboardPage/index.js | 9 +++-- src/components/SettingsPage/sections/About.js | 4 +-- static/images/empty-account-tile.svg | 34 +++++++++++++++++-- 3 files changed, 41 insertions(+), 6 deletions(-) diff --git a/src/components/DashboardPage/index.js b/src/components/DashboardPage/index.js index f9c0f3da..f652cb31 100644 --- a/src/components/DashboardPage/index.js +++ b/src/components/DashboardPage/index.js @@ -192,13 +192,17 @@ class DashboardPage extends PureComponent { /> ) : ( - + + + {t('app:dashboard.emptyAccountTile.desc')} @@ -247,4 +251,5 @@ const Wrapper = styled(Box).attrs({ })` border: 1px dashed ${p => p.theme.colors.fog}; border-radius: 4px; + height: 215px; ` diff --git a/src/components/SettingsPage/sections/About.js b/src/components/SettingsPage/sections/About.js index 24ef9871..b691e823 100644 --- a/src/components/SettingsPage/sections/About.js +++ b/src/components/SettingsPage/sections/About.js @@ -105,9 +105,9 @@ class AboutRowItem extends PureComponent<{ const { onClick, title, desc, url } = this.props const boundOnClick = () => onClick(url) return ( - + - + ) diff --git a/static/images/empty-account-tile.svg b/static/images/empty-account-tile.svg index 1e35c66b..359028c9 100644 --- a/static/images/empty-account-tile.svg +++ b/static/images/empty-account-tile.svg @@ -1,2 +1,32 @@ - - + + + + + + + + + + + + + + + + + + + + + From d583d88f0da5a843ec7572d162db922d7fa30c26 Mon Sep 17 00:00:00 2001 From: Anastasia Poupeney Date: Fri, 29 Jun 2018 12:30:48 +0200 Subject: [PATCH 2/2] change wording for market indicators --- static/i18n/en/app.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/static/i18n/en/app.yml b/static/i18n/en/app.yml index e85caab8..7a3544d5 100644 --- a/static/i18n/en/app.yml +++ b/static/i18n/en/app.yml @@ -312,7 +312,7 @@ settings: # Always ensure descriptions carry full stops (.) region: Region regionDesc: Choose the region in which you’re located to set the Ledger Live's time zone. stock: Regional market indicator - stockDesc: Choose Western to display an increase in market value in blue. Choose Eastern to display an increase in market value in red. + stockDesc: Choose Western to display an increase in market value in green. Choose Eastern to display an increase in market value in red. currencies: desc: Select a crypto asset to edit its settings. exchange: Rate provider ({{ticker}})