From 9a95b1a495d875b6c6f20652d00b23b13dde2a48 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ga=C3=ABtan=20Renaudeau?= <gaetan.renaudeau@ledger.fr>
Date: Sat, 30 Jun 2018 22:33:04 +0200
Subject: [PATCH] Fix many race conditions in Send step1

---
 src/components/FeesField/RippleKind.js              |  6 ++++++
 src/components/modals/Send/fields/AmountField.js    |  7 ++++---
 src/components/modals/Send/fields/RecipientField.js |  7 ++++---
 src/components/modals/Send/steps/01-step-amount.js  | 10 ++++++----
 4 files changed, 20 insertions(+), 10 deletions(-)

diff --git a/src/components/FeesField/RippleKind.js b/src/components/FeesField/RippleKind.js
index f40a22e5..f44c8b71 100644
--- a/src/components/FeesField/RippleKind.js
+++ b/src/components/FeesField/RippleKind.js
@@ -23,11 +23,17 @@ class FeesField extends Component<Props, State> {
   componentDidMount() {
     this.sync()
   }
+  componentWillUnmount() {
+    this.syncId++
+  }
+  syncId = 0
   async sync() {
     const api = apiForEndpointConfig(this.props.account.endpointConfig)
+    const syncId = ++this.syncId
     try {
       await api.connect()
       const info = await api.getServerInfo()
+      if (syncId !== this.syncId) return
       const serverFee = parseAPIValue(info.validatedLedger.baseFeeXRP)
       if (!this.props.fee) {
         this.props.onChange(serverFee)
diff --git a/src/components/modals/Send/fields/AmountField.js b/src/components/modals/Send/fields/AmountField.js
index 6605f5f3..3d5a25ef 100644
--- a/src/components/modals/Send/fields/AmountField.js
+++ b/src/components/modals/Send/fields/AmountField.js
@@ -20,13 +20,14 @@ class AmountField extends Component<*, { canBeSpent: boolean }> {
     }
   }
   componentWillUnmount() {
-    this.unmount = true
+    this.syncId++
   }
-  unmount = false
+  syncId = 0
   async resync() {
     const { account, bridge, transaction } = this.props
+    const syncId = ++this.syncId
     const canBeSpent = await bridge.canBeSpent(account, transaction)
-    if (this.unmount) return
+    if (this.syncId !== syncId) return
     this.setState({ canBeSpent })
   }
 
diff --git a/src/components/modals/Send/fields/RecipientField.js b/src/components/modals/Send/fields/RecipientField.js
index f01dd558..f7974c54 100644
--- a/src/components/modals/Send/fields/RecipientField.js
+++ b/src/components/modals/Send/fields/RecipientField.js
@@ -33,16 +33,17 @@ class RecipientField<Transaction> extends Component<Props<Transaction>, { isVali
     }
   }
   componentWillUnmount() {
-    this.unmount = true
+    this.syncId++
   }
-  unmount = false
+  syncId = 0
   async resync() {
     const { account, bridge, transaction } = this.props
+    const syncId = ++this.syncId
     const isValid = await bridge.isRecipientValid(
       account.currency,
       bridge.getTransactionRecipient(account, transaction),
     )
-    if (this.unmount) return
+    if (syncId !== this.syncId) return
     this.setState({ isValid })
   }
 
diff --git a/src/components/modals/Send/steps/01-step-amount.js b/src/components/modals/Send/steps/01-step-amount.js
index efa72337..0e2524d0 100644
--- a/src/components/modals/Send/steps/01-step-amount.js
+++ b/src/components/modals/Send/steps/01-step-amount.js
@@ -112,14 +112,16 @@ export class StepAmountFooter extends PureComponent<
   }
 
   componentWillUnmount() {
-    this._isUnmounted = true
+    this.syncId++
   }
 
-  _isUnmounted = false
+  syncId = 0
 
   async resync() {
     const { account, bridge, transaction } = this.props
 
+    const syncId = ++this.syncId
+
     if (!account || !transaction || !bridge) {
       return
     }
@@ -128,9 +130,9 @@ export class StepAmountFooter extends PureComponent<
 
     try {
       const totalSpent = await bridge.getTotalSpent(account, transaction)
-      if (this._isUnmounted) return
+      if (syncId !== this.syncId) return
       const canBeSpent = await bridge.canBeSpent(account, transaction)
-      if (this._isUnmounted) return
+      if (syncId !== this.syncId) return
       this.setState({ totalSpent, canBeSpent, isSyncing: false })
     } catch (err) {
       this.setState({ isSyncing: false })