From b076e7b3a82bd79ca87f723b4aa959afc78dc162 Mon Sep 17 00:00:00 2001
From: meriadec <meriadec.pillet@gmail.com>
Date: Mon, 16 Jul 2018 18:46:28 +0200
Subject: [PATCH] Zcash overwinter support

closes #904
---
 src/commands/libcoreSignAndBroadcast.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/commands/libcoreSignAndBroadcast.js b/src/commands/libcoreSignAndBroadcast.js
index 8b8e6bb2..14a8f063 100644
--- a/src/commands/libcoreSignAndBroadcast.js
+++ b/src/commands/libcoreSignAndBroadcast.js
@@ -77,7 +77,9 @@ async function signTransaction({
   hasTimestamp: boolean,
 }) {
   const additionals = []
+  let expiryHeight
   if (currencyId === 'bitcoin_cash' || currencyId === 'bitcoin_gold') additionals.push('bip143')
+  if (currencyId === 'zcash') expiryHeight = Buffer.from([0x00, 0x00, 0x00, 0x00])
   const rawInputs = transaction.getInputs()
 
   const inputs = await Promise.all(
@@ -119,7 +121,7 @@ async function signTransaction({
 
   const changePath = output ? output.getDerivationPath().toString() : undefined
   const outputScriptHex = Buffer.from(transaction.serializeOutputs()).toString('hex')
-  const lockTime = transaction.getLockTime()
+  const lockTime = undefined // TODO: transaction.getLockTime()
   const initialTimestamp = hasTimestamp ? transaction.getTimestamp() : undefined
 
   const signedTransaction = await hwApp.createPaymentTransactionNew(
@@ -132,6 +134,7 @@ async function signTransaction({
     isSegwit,
     initialTimestamp,
     additionals,
+    expiryHeight,
   )
 
   return signedTransaction