From 94af512180c4969cf50dcf0affd8d87a6b9a9f20 Mon Sep 17 00:00:00 2001 From: meriadec Date: Thu, 21 Jun 2018 15:05:42 +0200 Subject: [PATCH 01/16] Update our current Spinner to use live logo --- src/components/TopBar/ActivityIndicator.js | 6 +++--- src/components/base/Spinner.js | 4 ++-- src/icons/Loader.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/components/TopBar/ActivityIndicator.js b/src/components/TopBar/ActivityIndicator.js index 64de8714..5e1bed58 100644 --- a/src/components/TopBar/ActivityIndicator.js +++ b/src/components/TopBar/ActivityIndicator.js @@ -17,7 +17,7 @@ import { Rotating } from 'components/base/Spinner' import Tooltip from 'components/base/Tooltip' import TranslatedError from 'components/TranslatedError' import Box from 'components/base/Box' -import IconRefresh from 'icons/Refresh' +import IconLoader from 'icons/Loader' import IconExclamationCircle from 'icons/ExclamationCircle' import IconCheckCircle from 'icons/CheckCircle' import ItemContainer from './ItemContainer' @@ -93,13 +93,13 @@ class ActivityIndicatorInner extends PureComponent { {isError ? ( ) : isRotating ? ( - + ) : ( )} p.size}px; height: ${p => p.size}px; - animation: ${p => (p.isRotating === false ? 'none' : `${rotate} 1.5s linear infinite`)}; + animation: ${p => (p.isRotating === false ? 'none' : `${rotate} 1s linear infinite`)}; transition: 100ms linear transform; ` diff --git a/src/icons/Loader.js b/src/icons/Loader.js index 5c205762..921f15c1 100644 --- a/src/icons/Loader.js +++ b/src/icons/Loader.js @@ -5,12 +5,12 @@ import React from 'react' const path = ( ) export default ({ size, ...p }: { size: number }) => ( - + {path} ) From d5c98e4d9f2044a960aa6756930800b1b77cb3d6 Mon Sep 17 00:00:00 2001 From: meriadec Date: Thu, 21 Jun 2018 15:53:02 +0200 Subject: [PATCH 02/16] Update spinner color --- src/components/DeviceConnect/index.js | 2 +- src/components/TopBar/ActivityIndicator.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/DeviceConnect/index.js b/src/components/DeviceConnect/index.js index 4d784b20..bb94ea8d 100644 --- a/src/components/DeviceConnect/index.js +++ b/src/components/DeviceConnect/index.js @@ -131,7 +131,7 @@ const StepCheck = ({ checked, hasErrors }: { checked: boolean, hasErrors?: boole ) : ( - + )} ) diff --git a/src/components/TopBar/ActivityIndicator.js b/src/components/TopBar/ActivityIndicator.js index 5e1bed58..ee37de73 100644 --- a/src/components/TopBar/ActivityIndicator.js +++ b/src/components/TopBar/ActivityIndicator.js @@ -88,7 +88,7 @@ class ActivityIndicatorInner extends PureComponent { {isError ? ( From be693c4cfbf2e165fc17dc79ae6428b52f99c51d Mon Sep 17 00:00:00 2001 From: meriadec Date: Thu, 21 Jun 2018 16:00:28 +0200 Subject: [PATCH 03/16] Prevent storybook from crashing --- src/renderer/createStore.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/createStore.js b/src/renderer/createStore.js index f5d6a949..66dcf482 100644 --- a/src/renderer/createStore.js +++ b/src/renderer/createStore.js @@ -20,7 +20,7 @@ export default ({ state, history, dbMiddleware }: Props) => { history = createHistory() } const middlewares = [routerMiddleware(history), thunk, logger] - if (!__STORYBOOK_ENV__) { + if (!process.env.STORYBOOK_ENV) { middlewares.push(require('middlewares/sentry').default) } if (dbMiddleware) { From 663049d57fa868f2e0ebbf46ff4f9fb777e1406d Mon Sep 17 00:00:00 2001 From: meriadec Date: Thu, 21 Jun 2018 16:01:33 +0200 Subject: [PATCH 04/16] Dont use branch in CI dependencies cache key --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index b3cde252..06d84fbd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -15,13 +15,13 @@ jobs: - restore_cache: name: Restore Yarn Package Cache keys: - - v1-yarn-packages-{{ .Branch }}-{{ checksum "yarn.lock" }} + - v1-yarn-packages-{{ checksum "yarn.lock" }} - run: name: Install Dependencies command: bash scripts/install-ci-deps.sh - save_cache: name: Save Yarn Package Cache - key: v1-yarn-packages-{{ .Branch }}-{{ checksum "yarn.lock" }} + key: v1-yarn-packages-{{ checksum "yarn.lock" }} paths: - node_modules/ - run: From 7f18ae8f46773075068a98b0b1403fa82ce53cf2 Mon Sep 17 00:00:00 2001 From: Anastasia Poupeney Date: Thu, 21 Jun 2018 16:19:43 +0200 Subject: [PATCH 05/16] adding custom font for some wording in empty state account --- src/components/AccountPage/EmptyStateAccount.js | 14 +++++++++++--- src/components/DashboardPage/EmptyState.js | 5 +++-- static/i18n/en/app.yml | 4 ++-- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/src/components/AccountPage/EmptyStateAccount.js b/src/components/AccountPage/EmptyStateAccount.js index 507e1abc..b4457fb8 100644 --- a/src/components/AccountPage/EmptyStateAccount.js +++ b/src/components/AccountPage/EmptyStateAccount.js @@ -4,7 +4,7 @@ import React, { PureComponent } from 'react' import { i } from 'helpers/staticPath' import { connect } from 'react-redux' import { compose } from 'redux' -import { translate } from 'react-i18next' +import { translate, Trans } from 'react-i18next' import { openModal } from 'reducers/modals' import type { T } from 'types/common' @@ -13,6 +13,7 @@ import type { Account } from '@ledgerhq/live-common/lib/types' import { MODAL_RECEIVE } from 'config/constants' import Box from 'components/base/Box' +import Text from 'components/base/Text' import Button from 'components/base/Button' import { Title, Description } from 'components/DashboardPage/EmptyState' import IconReceive from 'icons/Receive' @@ -30,7 +31,6 @@ type Props = { class EmptyStateAccount extends PureComponent { render() { const { t, account, openModal } = this.props - return ( { /> {t('app:account.emptyState.title')} - {t('app:account.emptyState.desc')} + + + Make sure the + + {account.currency.name} + + app is installed to receive funds. + +