From fc463da721be514711c1a7317c7b2e852ec2cf03 Mon Sep 17 00:00:00 2001 From: meriadec Date: Tue, 17 Jul 2018 10:45:02 +0200 Subject: [PATCH] Document locktime temporary disable --- src/commands/libcoreSignAndBroadcast.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/commands/libcoreSignAndBroadcast.js b/src/commands/libcoreSignAndBroadcast.js index 14a8f063..07f36f7a 100644 --- a/src/commands/libcoreSignAndBroadcast.js +++ b/src/commands/libcoreSignAndBroadcast.js @@ -121,9 +121,14 @@ async function signTransaction({ const changePath = output ? output.getDerivationPath().toString() : undefined const outputScriptHex = Buffer.from(transaction.serializeOutputs()).toString('hex') - const lockTime = undefined // TODO: transaction.getLockTime() const initialTimestamp = hasTimestamp ? transaction.getTimestamp() : undefined + // FIXME + // should be `transaction.getLockTime()` as soon as lock time is + // handled by libcore (actually: it always returns a default value + // and that caused issue with zcash (see #904)) + const lockTime = undefined + const signedTransaction = await hwApp.createPaymentTransactionNew( inputs, associatedKeysets,