lukechilds
/
lightning
mirror of https://github.com/lukechilds/lightning.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
5284 Commits
55 Branches
107 Tags
38 MiB
Branch: issue-2080
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'issue-2080'
${ noResults }
lightning/connectd/netaddress.h

15 lines
460 B
Raw Permalink Normal View History

gossipd: move files into connectd. These source files are only used for peer-related things, so move them. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
#ifndef LIGHTNING_CONNECTD_NETADDRESS_H
#define LIGHTNING_CONNECTD_NETADDRESS_H
gossipd: take over address determination, from master. It does all the other address handling, do this too. It also proves useful as we clean up wildcard address handling. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
#include "config.h"
#include <ccan/short_types/short_types.h>
gossipd/lightningd: use wireaddr_internal. This replacement is a little menial, but it explicitly catches all the places where we allow a local socket. The actual implementation of opening a AF_UNIX socket is almost hidden in the patch. The detection of &#34;valid address&#34; is now more complex: p-&gt;addr.itype != ADDR_INTERNAL_WIREADDR || p-&gt;addr.u.wireaddr.type != ADDR_TYPE_PADDING But most places we do this, we should audit: I&#39;m pretty sure we can&#39;t get an invalid address any more from gossipd (they may be in db, but we should fix that too). Closes: #1323 Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
#include <common/wireaddr.h>
gossipd: take over address determination, from master. It does all the other address handling, do this too. It also proves useful as we clean up wildcard address handling. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
gossipd: handle wildcard addresses correctly. If we&#39;re given a wildcard address, we can&#39;t announce it like that: we need to try to turn it into a real address (using guess_address). Then we use that address. As a side-effect of this cleanup, we only announce *any* &#39;--addr&#39; if it&#39;s routable. This fix means that our tests have to force &#39;--announce-addr&#39; because otherwise localhost isn&#39;t routable. This means that gossipd really controls the addresses now, and breaks them into two arrays: what we bind to, and what we announce. That is now what we return to the master for json_getinfo(), which prints them as &#39;bindings&#39; and &#39;addresses&#39; respectively. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
/* Address is a wildcard: try to guess what it looks like to outside world */
bool guess_address(struct wireaddr *wireaddr);
/* Is this address public? */
gossipd: don&#39;t try to connect to non-routable addresses. Someone could try to announce an internal address, and we might probe it. This breaks tests, so we add &#39;--dev-allow-localhost&#39; for our tests, so we don&#39;t eliminate that one. Of course, now we need to skip some more tests in non-developer mode. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
bool address_routable(const struct wireaddr *wireaddr,
bool allow_localhost);
gossipd: take over address determination, from master. It does all the other address handling, do this too. It also proves useful as we clean up wildcard address handling. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
gossipd: move files into connectd. These source files are only used for peer-related things, so move them. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
#endif /* LIGHTNING_CONNECTD_NETADDRESS_H */