lukechilds
/
lightning
mirror of https://github.com/lukechilds/lightning.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
5318 Commits
55 Branches
107 Tags
38 MiB
Tree: 02faadfb93
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '02faadfb93'
${ noResults }
lightning/lightningd/channel_control.h

27 lines
768 B
Raw Normal View History

lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
#ifndef LIGHTNING_LIGHTNINGD_CHANNEL_CONTROL_H
#define LIGHTNING_LIGHTNINGD_CHANNEL_CONTROL_H
#include "config.h"
#include <ccan/short_types/short_types.h>
#include <stdbool.h>
struct channel;
struct crypto_state;
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
struct lightningd;
lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
lightningd: peer_start_channeld always returns true; make it void. It is always true, and we always ignore it. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
6 years ago
void peer_start_channeld(struct channel *channel,
lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
const struct crypto_state *cs,
int peer_fd, int gossip_fd,
const u8 *funding_signed,
bool reconnected);
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
/* Returns true if subd told, otherwise false. */
bool channel_tell_funding_locked(struct lightningd *ld,
struct channel *channel,
channeld: simplify announce/locked-in callback, Just have a &#34;new depth&#34; callback, and let channeld do the right thing. This makes the channeld paths a bit more straightforward. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
const struct bitcoin_txid *txid,
u32 depth);
channel_control: Forget if unconfirmed for a long time and we are fundee. We should forget this as it is a potential DoS if we remember every funding txid that an attacker gave in a `funding_created` but never broadcasted.
7 years ago
/* Notify channels of new blocks. */
void channel_notify_new_block(struct lightningd *ld,
u32 block_height);
channeld: don&#39;t do explicit state update. We missed it in some corner cases where we crashed/were killed between being told of the lockin and sending the channel_normal_operation message. When we were restarted, we were told both sides were locked in already, so we never updated the state. Pull the entire &#34;tell channeld&#34; logic into channel_control.c, and make it clear that we need to keep waching if we cant&#39;t tell channeld. I think we did get this correct in practice, since funding_announce_cb has the same test, but it&#39;s better to be clear. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
lightningd/channel_control: routines to control channeld (move from peer_control.c) Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
#endif /* LIGHTNING_LIGHTNINGD_CHANNEL_CONTROL_H */