lukechilds
/
lightning
mirror of https://github.com/lukechilds/lightning.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
5049 Commits
55 Branches
107 Tags
38 MiB
Tree: 0d5f0d79da
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0d5f0d79da'
${ noResults }
lightning/common/peer_failed.h

35 lines
1.0 KiB
Raw Normal View History

headers: fix up header idempotent lines. For future reference, done via: for f in `find wire/ bitcoin/ common/ lightningd -name '*.h' ! -name 'gen*'`; do ID=`echo -n LIGHTNING/$f | tr 'a-z' 'A-Z' | tr -cs 'A-Z0-9' _`; sed 's/^#\(ifndef\|define\) .*_H$/#\1 '$ID/ < $f | sed 's,#endif /..*_H ./$,#endif /* '$ID' */,' | bagto $f; done Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years ago
#ifndef LIGHTNING_COMMON_PEER_FAILED_H
#define LIGHTNING_COMMON_PEER_FAILED_H
lightningd/peer_failed: helper to send PKT_ERR and exit daemon. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years ago
#include "config.h"
#include <ccan/compiler/compiler.h>
#include <ccan/short_types/short_types.h>
struct channel_id;
/**
peer_failed: automatically hand PEER_FD, GOSSIP_FD; add gossip_index We make it a macro, since everyone uses PEER_FD and GOSSIP_FD constants (they&#39;re actually always the same, but this is slightly safer), and add a gossip_index arg: this is groundwork for when we want to hand the peer back to master for gossipd. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
* peer_failed - Exit with error for peer.
lightningd/peer_failed: helper to send PKT_ERR and exit daemon. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
8 years ago
* @cs: the peer's current crypto state.
* @channel_id: channel with error, or NULL for all.
peer_failed: automatically hand PEER_FD, GOSSIP_FD; add gossip_index We make it a macro, since everyone uses PEER_FD and GOSSIP_FD constants (they&#39;re actually always the same, but this is slightly safer), and add a gossip_index arg: this is groundwork for when we want to hand the peer back to master for gossipd. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
* @fmt...: format as per status_failed(STATUS_FAIL_PEER_BAD)
lightningd/peer_failed: helper to send PKT_ERR and exit daemon. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
8 years ago
*/
gossipd: drain fd instead of passing around gossip index. (This was sitting in my gossip-enchancement patch queue, but it simplifies this set too, so I moved it here). In 94711969f we added an explicit gossip_index so when gossipd gets peers back from other daemons, it knows what gossip it has sent (since gossipd can send gossip after the other daemon is already complete). This solution is insufficient for the more general case where gossipd wants to send other messages reliably, so replace it with the other solution: have gossipd drain the &#34;gossip fd&#34; which the daemon returns. This turns out to be quite simple, and is probably how I should have done it originally :( Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
#define peer_failed(cs, channel_id, ...) \
peer_failed_(PEER_FD, GOSSIP_FD, (cs), (channel_id), __VA_ARGS__)
peer_failed: automatically hand PEER_FD, GOSSIP_FD; add gossip_index We make it a macro, since everyone uses PEER_FD and GOSSIP_FD constants (they&#39;re actually always the same, but this is slightly safer), and add a gossip_index arg: this is groundwork for when we want to hand the peer back to master for gossipd. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
void peer_failed_(int peer_fd, int gossip_fd,
gossipd: drain fd instead of passing around gossip index. (This was sitting in my gossip-enchancement patch queue, but it simplifies this set too, so I moved it here). In 94711969f we added an explicit gossip_index so when gossipd gets peers back from other daemons, it knows what gossip it has sent (since gossipd can send gossip after the other daemon is already complete). This solution is insufficient for the more general case where gossipd wants to send other messages reliably, so replace it with the other solution: have gossipd drain the &#34;gossip fd&#34; which the daemon returns. This turns out to be quite simple, and is probably how I should have done it originally :( Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
struct crypto_state *cs,
peer_failed: automatically hand PEER_FD, GOSSIP_FD; add gossip_index We make it a macro, since everyone uses PEER_FD and GOSSIP_FD constants (they&#39;re actually always the same, but this is slightly safer), and add a gossip_index arg: this is groundwork for when we want to hand the peer back to master for gossipd. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
const struct channel_id *channel_id,
const char *fmt, ...)
gossipd: drain fd instead of passing around gossip index. (This was sitting in my gossip-enchancement patch queue, but it simplifies this set too, so I moved it here). In 94711969f we added an explicit gossip_index so when gossipd gets peers back from other daemons, it knows what gossip it has sent (since gossipd can send gossip after the other daemon is already complete). This solution is insufficient for the more general case where gossipd wants to send other messages reliably, so replace it with the other solution: have gossipd drain the &#34;gossip fd&#34; which the daemon returns. This turns out to be quite simple, and is probably how I should have done it originally :( Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
PRINTF_FMT(5,6) NORETURN;
status: split off error messages into a new &#39;peer_status&#39; type. Several daemons (onchaind, hsm) want to use the status messages, but don&#39;t communicate with peers. The coming changes made them drag in more code they didn&#39;t need, so instead we have a different non-overlapping type. We combine the status_received_errmsg and status_sent_errmsg into a single status_peer_error, with the presence or not of the &#39;error_for_them&#39; field indicating direction. We also rename status_fatal_connection_lost() to peer_failed_connection_lost() to fit in. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
common/read_peer_msg: deconstruct into individual helper routines. The One Big API is confusing, and has enough corner cases that we should ditch it rather than add more. See: https://www.sandimetz.com/blog/2016/1/20/the-wrong-abstraction In particular, when openingd is changed to chat to peers even when it&#39;s not actively opening a channel, it wants to handle (most) errors by continuing, not calling peer_failed(). This exposes the constituent parts. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
6 years ago
/* We're failing because peer sent us an error message: NULL
* channel_id means all channels. */
status: split off error messages into a new &#39;peer_status&#39; type. Several daemons (onchaind, hsm) want to use the status messages, but don&#39;t communicate with peers. The coming changes made them drag in more code they didn&#39;t need, so instead we have a different non-overlapping type. We combine the status_received_errmsg and status_sent_errmsg into a single status_peer_error, with the presence or not of the &#39;error_for_them&#39; field indicating direction. We also rename status_fatal_connection_lost() to peer_failed_connection_lost() to fit in. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
void peer_failed_received_errmsg(int peer_fd, int gossip_fd,
gossipd: drain fd instead of passing around gossip index. (This was sitting in my gossip-enchancement patch queue, but it simplifies this set too, so I moved it here). In 94711969f we added an explicit gossip_index so when gossipd gets peers back from other daemons, it knows what gossip it has sent (since gossipd can send gossip after the other daemon is already complete). This solution is insufficient for the more general case where gossipd wants to send other messages reliably, so replace it with the other solution: have gossipd drain the &#34;gossip fd&#34; which the daemon returns. This turns out to be quite simple, and is probably how I should have done it originally :( Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
struct crypto_state *cs,
status: split off error messages into a new &#39;peer_status&#39; type. Several daemons (onchaind, hsm) want to use the status messages, but don&#39;t communicate with peers. The coming changes made them drag in more code they didn&#39;t need, so instead we have a different non-overlapping type. We combine the status_received_errmsg and status_sent_errmsg into a single status_peer_error, with the presence or not of the &#39;error_for_them&#39; field indicating direction. We also rename status_fatal_connection_lost() to peer_failed_connection_lost() to fit in. Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
const char *desc,
const struct channel_id *channel_id) NORETURN;
/* I/O error */
void peer_failed_connection_lost(void) NORETURN;
headers: fix up header idempotent lines. For future reference, done via: for f in `find wire/ bitcoin/ common/ lightningd -name &#39;*.h&#39; ! -name &#39;gen*&#39;`; do ID=`echo -n LIGHTNING/$f | tr &#39;a-z&#39; &#39;A-Z&#39; | tr -cs &#39;A-Z0-9&#39; _`; sed &#39;s/^#\(ifndef\|define\) .*_H$/#\1 &#39;$ID/ &lt; $f | sed &#39;s,#endif /..*_H ./$,#endif /* &#39;$ID&#39; */,&#39; | bagto $f; done Signed-off-by: Rusty Russell &lt;rusty@rustcorp.com.au&gt;
7 years ago
#endif /* LIGHTNING_COMMON_PEER_FAILED_H */